Remove transcript credentials and preferences view #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DawoudSheraz
approved these changes
May 18, 2020
|
Remember to bump the version in setup.py before merging. |
|
Devops Ticket for review: https://openedx.atlassian.net/browse/DOS-1140 Version will be updated in next PR, where we remove the |
adzuci
reviewed
May 20, 2020
| operations = [ | ||
| migrations.DeleteModel( | ||
| name='TranscriptCredentials', | ||
| ), |
There was a problem hiding this comment.
Do you need to do this in two PRs, one for the code change and one for the migration?
Also, could we add a reverse migration to put this back just in case / to follow best practices?
There was a problem hiding this comment.
I will update the PR to separate code changes and migration changes
zainab-amir
force-pushed
the
zamir/PROD-1597/remove_transcript_credentials_and_pref_view
branch
from
34fe8d0
to
970b699
Compare
zainab-amir
force-pushed
the
zamir/PROD-1597/remove_transcript_credentials_and_pref_view
branch
from
bf368af
to
797f9bf
Compare
DawoudSheraz
approved these changes
May 21, 2020
zainab-amir
deleted the
zamir/PROD-1597/remove_transcript_credentials_and_pref_view
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With our decision to move the transcript preferences and credential model to VEM, we no longer need following in edx-val:
Ticket: PROD-1597
NOTE:
Currently
TranscriptCredentialsmodel has only 21 db records in production