feat: allow runtime configuration

[dcoa]

Description

This PR allows the app to change the favicon and the site name in the title tag at runtime and serves as a discussion.

This is part of a work to make it possible to configure the frontend applications at runtime (you can referer to this FWG issue).

This PR depend on openedx/frontend-platform#335

The changes are grouped in a component Head, that uses Helmet library and integrates internationalization to change the MFE name in the title tag according to the language.

[openedx-webhooks]

Thanks for the pull request, @dcoa! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[natabene]

@dcoa Thank you for your contribution. Please let me know once it is ready for our review.

[dcoa]

Hi @natabene this PR is ready for review.

[codecov]

Codecov Report

Merging #603 (cb80cfc) into master (f9d04e4) will increase coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head cb80cfc differs from pull request most recent head 5462815. Consider uploading reports for the commit 5462815 to get more accurate results

@@            Coverage Diff             @@
##           master     #603      +/-   ##
==========================================
+ Coverage   39.58%   39.69%   +0.11%     
==========================================
  Files         106      108       +2     
  Lines        2190     2194       +4     
  Branches      586      586              
==========================================
+ Hits          867      871       +4     
  Misses       1238     1238              
  Partials       85       85              

Impacted Files	Coverage Δ
src/index.jsx	0.00% <ø> (ø)
src/head/Head.jsx	100.00% <100.00%> (ø)
src/head/messages.js	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[MaferMazu]

@arbrandes I think you might like to take a look at this.

[dcoa]

@natabene could you help me re-run the test, please?

[davidjoy]

The i18n/messages/*.json files should not be updated manually - they are generated and will be overridden and updated by the transifex/translations jobs. The new English language messages.js file content is sufficient. 👍🏻

I think this looks good otherwise.

[davidjoy]

I think this looks good! Don't think we need to wait for any of the other runtime config PRs to merge this, right? It should work regardless of whether we're actually setting config at runtime. If you agree, I can get it merged once we see the tests pass.

[dcoa]

Yes, PR does not affect the actual app behavior but I wonder if it's better to use this to change the dependency once frontend-platform has been updated and backport only 1 commit to the nutmeg release.

[davidjoy]

Seems reasonable - I don't feel strongly either way.

[robrap]

@davidjoy: Will you be merging this?

[davidjoy]

From @dcoa's comment above, I think we're waiting to use this PR to update the frontend-platform dependency once openedx/frontend-platform#335 merges. @dcoa, let me know if that's not what you intended and I can just merge this!

[dcoa]

Yes, I'm waiting for frontend-platform to update it in this PR

[arbrandes]

LGTM as well.

[dcoa]

Hello, just an update here, to make it possible to update the package-lock.json (with the new frontend-platform version) a peer dependency error has to be resolved (this PR does that #611 )

[dcoa]

Hi, @davidjoy @arbrandes someone has already fixed the peer dependency error, and I was able to update the package.json and package-lock.json the PR is ready with all changes, Could you run the test and review it?
Thanks :)

[davidjoy]

Argh - it says the branch has conflicts that must be resolved but isn't showing which files. Apologies, that may be because of the delay in review and something else went into the master branch.

I just tested this, seems to work well. If we can get that conflict resolved I'll push the merge button.

[dcoa]

Hi hi 🖖, now the conflict is resolved. 😊

[openedx-webhooks]

@dcoa 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.