perf: preload MFE Config API response in index.html #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, a capability was added to this MFE that allows it to load configuration from an the LMS's MFE Config API instead of requiring it to be baked-in to the webpack build. When enabled, though, this capability blocks any render of the MFE until the Config API responds. So, in order to minimize the amount of time that the MFE is waiting on the Config API response, we preload the API response via a in the section of index.html, which recommends to the browser to immediately begin loading the MFE Config API response as soon as index.html is loaded. Otherwise, the Config API wouldn't be called until React and frontend-platform are loaded. Recently, a capability was added to MFE that allows it to load configuration from an LMS API (the "MFE Config API") instead of requiring it to be baked-in to the webpack build. Related to: * https://github.com/overhangio/2u-tutor-adoption/issues/87 * openedx/wg-frontend#103
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
=======================================
Coverage 39.24% 39.24%
=======================================
Files 109 109
Lines 2227 2227
Branches 597 597
=======================================
Hits 874 874
Misses 1268 1268
Partials 85 85 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Closing because it's not clear that this optimization is necessary. See openedx/frontend-platform#360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, a capability was added to this MFE that allows it
to load configuration from an the LMS's MFE Config
API instead of requiring it to be baked-in to the webpack
build.
When enabled, though, this capability blocks any render
of the MFE until the Config API responds. So, in order to
minimize the amount of time that the MFE is waiting
on the Config API response, we preload the API
response via a in the section
of index.html, which recommends to the browser
to immediately begin loading the MFE Config API
response as soon as index.html is loaded. Otherwise,
the Config API wouldn't be called until React and
frontend-platform are loaded.
Recently, a capability was added to MFE that allows it
to load configuration from an LMS API (the "MFE Config
API") instead of requiring it to be baked-in to the webpack
build.
Related to: