fix: special characters in redirect url getting decoded to space #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1029 +/- ##
==========================================
+ Coverage 84.46% 84.47% +0.01%
==========================================
Files 113 113
Lines 2195 2197 +2
Branches 636 638 +2
==========================================
+ Hits 1854 1856 +2
Misses 325 325
Partials 16 16
☔ View full report in Codecov by Sentry. |
zainab-amir
approved these changes
Aug 15, 2023
syedsajjadkazmii
added a commit
that referenced
this pull request
Aug 16, 2023
ahtesham-quraish
pushed a commit
that referenced
this pull request
Aug 22, 2023
mubbsharanwar
pushed a commit
that referenced
this pull request
Aug 28, 2023
zainab-amir
pushed a commit
that referenced
this pull request
Sep 7, 2023
syedsajjadkazmii
added a commit
that referenced
this pull request
Sep 8, 2023
* feat: add personalized recommendations (#1024) * use Algolia for personalized recommendations * show personalized recommendations to use that have consented to functional cookies * update tests VAN-1599 * Revert "fix: special characters in redirect url getting decoded to space (#1029)" (#1030) This reverts commit fc62241. * feat: update recommendations page design (#1036) VAN-1598 * feat: add events for recommendations (#1039) * feat: remove static recommendations --------- Co-authored-by: Syed Sajjad Hussain Shah <52817156+syedsajjadkazmii@users.noreply.github.com>
snglth
pushed a commit
to Abstract-Tech/community-theme-authn
that referenced
this pull request
Jan 9, 2024
snglth
pushed a commit
to Abstract-Tech/community-theme-authn
that referenced
this pull request
Jan 9, 2024
…ace (openedx#1029)" (openedx#1030) This reverts commit fc62241.
snglth
pushed a commit
to Abstract-Tech/community-theme-authn
that referenced
this pull request
Jan 9, 2024
* feat: add personalized recommendations (openedx#1024) * use Algolia for personalized recommendations * show personalized recommendations to use that have consented to functional cookies * update tests VAN-1599 * Revert "fix: special characters in redirect url getting decoded to space (openedx#1029)" (openedx#1030) This reverts commit fc62241. * feat: update recommendations page design (openedx#1036) VAN-1598 * feat: add events for recommendations (openedx#1039) * feat: remove static recommendations --------- Co-authored-by: Syed Sajjad Hussain Shah <52817156+syedsajjadkazmii@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In registration embedded experinece, if next Url contains
+, it gets decoded toHow Has This Been Tested?
locally
Screenshots/sandbox (optional):
Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if its not applicable.
Merge Checklist
Post-merge Checklist