Add events for recommendations #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zainab-amir
force-pushed
the
zamir/VAN-1600/add_events_for_recommendations
branch
2 times, most recently
from
78abaef
to
04ae5e7
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## recommendations-v2 #1039 +/- ##
=====================================================
Coverage ? 85.98%
=====================================================
Files ? 121
Lines ? 2291
Branches ? 658
=====================================================
Hits ? 1970
Misses ? 310
Partials ? 11 ☔ View full report in Codecov by Sentry. |
mubbsharanwar
approved these changes
Aug 21, 2023
| import { DEFAULT_REDIRECT_URL } from '../data/constants'; | ||
|
|
||
| const RecommendationsPage = ({ location }) => { | ||
| const { formatMessage } = useIntl(); | ||
| const registrationResponse = location.state?.registrationResult; | ||
| const educationLevel = EDUCATION_LEVEL_MAPPING[location.state?.educationLevel]; | ||
| const userId = location.state?.userId; | ||
| const userId = location.state?.userId || 1234; |
There was a problem hiding this comment.
Why do we need to set the default value here for userId?
There was a problem hiding this comment.
Sorry, this was added for debugging.
zainab-amir
force-pushed
the
zamir/VAN-1600/add_events_for_recommendations
branch
from
68774ca
to
fbea2ea
Compare
ahtesham-quraish
pushed a commit
that referenced
this pull request
Aug 22, 2023
mubbsharanwar
pushed a commit
that referenced
this pull request
Aug 23, 2023
mubbsharanwar
added a commit
that referenced
this pull request
Aug 24, 2023
* feat: add events for recommendations (#1039) * fix: Post registration feedback changes fix Post registration recommendations background color and label VAN-1616 --------- Co-authored-by: Zainab Amir <zainab.amir@arbisoft.com>
mubbsharanwar
pushed a commit
that referenced
this pull request
Aug 28, 2023
mubbsharanwar
added a commit
that referenced
this pull request
Aug 28, 2023
* feat: add events for recommendations (#1039) * fix: Post registration feedback changes fix Post registration recommendations background color and label VAN-1616 --------- Co-authored-by: Zainab Amir <zainab.amir@arbisoft.com>
zainab-amir
added a commit
that referenced
this pull request
Sep 7, 2023
zainab-amir
added a commit
that referenced
this pull request
Sep 7, 2023
* feat: add events for recommendations (#1039) * fix: Post registration feedback changes fix Post registration recommendations background color and label VAN-1616 --------- Co-authored-by: Zainab Amir <zainab.amir@arbisoft.com>
zainab-amir
added a commit
that referenced
this pull request
Sep 7, 2023
syedsajjadkazmii
added a commit
that referenced
this pull request
Sep 8, 2023
* feat: add personalized recommendations (#1024) * use Algolia for personalized recommendations * show personalized recommendations to use that have consented to functional cookies * update tests VAN-1599 * Revert "fix: special characters in redirect url getting decoded to space (#1029)" (#1030) This reverts commit fc62241. * feat: update recommendations page design (#1036) VAN-1598 * feat: add events for recommendations (#1039) * feat: remove static recommendations --------- Co-authored-by: Syed Sajjad Hussain Shah <52817156+syedsajjadkazmii@users.noreply.github.com>
snglth
pushed a commit
to Abstract-Tech/community-theme-authn
that referenced
this pull request
Jan 9, 2024
* feat: add personalized recommendations (openedx#1024) * use Algolia for personalized recommendations * show personalized recommendations to use that have consented to functional cookies * update tests VAN-1599 * Revert "fix: special characters in redirect url getting decoded to space (openedx#1029)" (openedx#1030) This reverts commit fc62241. * feat: update recommendations page design (openedx#1036) VAN-1598 * feat: add events for recommendations (openedx#1039) * feat: remove static recommendations --------- Co-authored-by: Syed Sajjad Hussain Shah <52817156+syedsajjadkazmii@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added events for recommendations shown after registration. Event details can be found in the ticket description.
JIRA
VAN-1600
How Has This Been Tested?