Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch algolia recommendations #1024

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

syedsajjadkazmii
Copy link
Contributor

@syedsajjadkazmii syedsajjadkazmii commented Aug 8, 2023

Description

  • Adds logic to fetch Algolia recommendations for post registration recommendations

JIRA

VAN-1599

How Has This Been Tested?

Locally

@syedsajjadkazmii syedsajjadkazmii requested a review from a team as a code owner August 8, 2023 11:55
@syedsajjadkazmii syedsajjadkazmii marked this pull request as draft August 8, 2023 11:55
@syedsajjadkazmii syedsajjadkazmii force-pushed the sajjad/VAN-1599 branch 5 times, most recently from 04e007c to e3bba48 Compare August 9, 2023 13:39
@openedx openedx deleted a comment from codecov bot Aug 9, 2023
src/recommendations/data/algoliaResultsParser.js Outdated Show resolved Hide resolved
src/data/algolia.js Outdated Show resolved Hide resolved
src/recommendations/data/tests/hooks.test.jsx Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.21% 🎉

Comparison is base (fc62241) 84.47% compared to head (2f9e04d) 85.69%.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           recommendations-v2    #1024      +/-   ##
======================================================
+ Coverage               84.47%   85.69%   +1.21%     
======================================================
  Files                     113      119       +6     
  Lines                    2197     2258      +61     
  Branches                  638      642       +4     
======================================================
+ Hits                     1856     1935      +79     
+ Misses                    325      310      -15     
+ Partials                   16       13       -3     
Files Changed Coverage Δ
src/data/algolia.js 100.00% <100.00%> (ø)
src/data/oneTrust.js 100.00% <100.00%> (ø)
src/data/utils/dataUtils.js 93.33% <100.00%> (-0.29%) ⬇️
src/recommendations/RecommendationsPage.jsx 86.20% <100.00%> (ø)
src/recommendations/data/algoliaResultsParser.js 100.00% <100.00%> (ø)
src/recommendations/data/constants.js 100.00% <100.00%> (ø)
...endations/data/hooks/useAlgoliaRecommendations.jsx 100.00% <100.00%> (ø)
.../recommendations/data/hooks/useRecommendations.jsx 100.00% <100.00%> (ø)
...mendations/data/hooks/useStaticRecommendations.jsx 100.00% <100.00%> (ø)
src/recommendations/data/tests/mockedData.js 100.00% <100.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syedsajjadkazmii syedsajjadkazmii force-pushed the sajjad/VAN-1599 branch 3 times, most recently from c0a83db to 0c7483d Compare August 10, 2023 11:56
@syedsajjadkazmii syedsajjadkazmii marked this pull request as ready for review August 15, 2023 11:12
@syedsajjadkazmii syedsajjadkazmii changed the base branch from master to recommendations-v2 August 15, 2023 11:12
@syedsajjadkazmii syedsajjadkazmii merged commit 7ca12b6 into recommendations-v2 Aug 16, 2023
6 checks passed
@syedsajjadkazmii syedsajjadkazmii deleted the sajjad/VAN-1599 branch August 16, 2023 04:11
ahtesham-quraish pushed a commit that referenced this pull request Aug 22, 2023
* feat: fetch algolia recommendations

VAN-1599

* Revert "fix: special characters in redirect url getting decoded to space (#1029)" (#1030)

This reverts commit fc62241.
mubbsharanwar pushed a commit that referenced this pull request Aug 28, 2023
* feat: fetch algolia recommendations

VAN-1599

* Revert "fix: special characters in redirect url getting decoded to space (#1029)" (#1030)

This reverts commit fc62241.
zainab-amir pushed a commit that referenced this pull request Sep 7, 2023
* feat: fetch algolia recommendations

VAN-1599

* Revert "fix: special characters in redirect url getting decoded to space (#1029)" (#1030)

This reverts commit fc62241.
zainab-amir pushed a commit that referenced this pull request Sep 7, 2023
* use Algolia for personalized recommendations
* show personalized recommendations to use that have consented
to functional cookies
* update tests

VAN-1599

* Revert "fix: special characters in redirect url getting decoded to space (#1029)" (#1030)

This reverts commit fc62241.
syedsajjadkazmii added a commit that referenced this pull request Sep 8, 2023
* feat: add personalized recommendations (#1024)

* use Algolia for personalized recommendations
* show personalized recommendations to use that have consented
to functional cookies
* update tests

VAN-1599

* Revert "fix: special characters in redirect url getting decoded to space (#1029)" (#1030)

This reverts commit fc62241.

* feat: update recommendations page design (#1036)

VAN-1598

* feat: add events for recommendations (#1039)

* feat: remove static recommendations

---------

Co-authored-by: Syed Sajjad Hussain Shah <52817156+syedsajjadkazmii@users.noreply.github.com>
snglth pushed a commit to Abstract-Tech/community-theme-authn that referenced this pull request Jan 9, 2024
* feat: add personalized recommendations (openedx#1024)

* use Algolia for personalized recommendations
* show personalized recommendations to use that have consented
to functional cookies
* update tests

VAN-1599

* Revert "fix: special characters in redirect url getting decoded to space (openedx#1029)" (openedx#1030)

This reverts commit fc62241.

* feat: update recommendations page design (openedx#1036)

VAN-1598

* feat: add events for recommendations (openedx#1039)

* feat: remove static recommendations

---------

Co-authored-by: Syed Sajjad Hussain Shah <52817156+syedsajjadkazmii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants