generated from openedx/frontend-template-application
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update recommendations page design #1036
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syedsajjadkazmii
force-pushed
the
sajjad/VAN-1598
branch
2 times, most recently
from
August 16, 2023 05:36
1e6a3a8
to
44f18aa
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## recommendations-v2 #1036 +/- ##
=====================================================
Coverage ? 85.87%
=====================================================
Files ? 122
Lines ? 2286
Branches ? 655
=====================================================
Hits ? 1963
Misses ? 310
Partials ? 13 ☔ View full report in Codecov by Sentry. |
syedsajjadkazmii
force-pushed
the
sajjad/VAN-1598
branch
from
August 16, 2023 10:02
44f18aa
to
a01bf0e
Compare
mubbsharanwar
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks, good with some queries.
syedsajjadkazmii
force-pushed
the
sajjad/VAN-1598
branch
from
August 16, 2023 12:01
a01bf0e
to
75cb299
Compare
syedsajjadkazmii
force-pushed
the
sajjad/VAN-1598
branch
from
August 16, 2023 12:04
75cb299
to
9999163
Compare
ahtesham-quraish
pushed a commit
that referenced
this pull request
Aug 22, 2023
mubbsharanwar
pushed a commit
that referenced
this pull request
Aug 28, 2023
zainab-amir
pushed a commit
that referenced
this pull request
Sep 7, 2023
zainab-amir
pushed a commit
that referenced
this pull request
Sep 7, 2023
syedsajjadkazmii
added a commit
that referenced
this pull request
Sep 8, 2023
* feat: add personalized recommendations (#1024) * use Algolia for personalized recommendations * show personalized recommendations to use that have consented to functional cookies * update tests VAN-1599 * Revert "fix: special characters in redirect url getting decoded to space (#1029)" (#1030) This reverts commit fc62241. * feat: update recommendations page design (#1036) VAN-1598 * feat: add events for recommendations (#1039) * feat: remove static recommendations --------- Co-authored-by: Syed Sajjad Hussain Shah <52817156+syedsajjadkazmii@users.noreply.github.com>
snglth
pushed a commit
to Abstract-Tech/community-theme-authn
that referenced
this pull request
Jan 9, 2024
* feat: add personalized recommendations (openedx#1024) * use Algolia for personalized recommendations * show personalized recommendations to use that have consented to functional cookies * update tests VAN-1599 * Revert "fix: special characters in redirect url getting decoded to space (openedx#1029)" (openedx#1030) This reverts commit fc62241. * feat: update recommendations page design (openedx#1036) VAN-1598 * feat: add events for recommendations (openedx#1039) * feat: remove static recommendations --------- Co-authored-by: Syed Sajjad Hussain Shah <52817156+syedsajjadkazmii@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VAN-1598
Description
Update Post registration recommendations design according to Figma
JIRA
VAN-1598
How Has This Been Tested?
locally
Screenshots/sandbox (optional):