Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update recommendations page design #1036

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

syedsajjadkazmii
Copy link
Contributor

@syedsajjadkazmii syedsajjadkazmii commented Aug 16, 2023

VAN-1598

Description

Update Post registration recommendations design according to Figma

JIRA

VAN-1598

How Has This Been Tested?

locally

Screenshots/sandbox (optional):

Screen size Loading state Recommendations
X Large Screenshot 2023-08-16 at 10 15 49 AM Screenshot 2023-08-16 at 10 18 40 AM
Large Screenshot 2023-08-16 at 10 17 03 AM
Medium Screenshot 2023-08-16 at 10 16 24 AM Screenshot 2023-08-16 at 10 18 57 AM
Tab Screenshot 2023-08-16 at 10 16 36 AM
Small Screenshot 2023-08-16 at 10 16 12 AM Screenshot 2023-08-16 at 10 19 15 AM

@syedsajjadkazmii syedsajjadkazmii requested a review from a team as a code owner August 16, 2023 05:21
@syedsajjadkazmii syedsajjadkazmii force-pushed the sajjad/VAN-1598 branch 2 times, most recently from 1e6a3a8 to 44f18aa Compare August 16, 2023 05:36
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (recommendations-v2@7ca12b6). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             recommendations-v2    #1036   +/-   ##
=====================================================
  Coverage                      ?   85.87%           
=====================================================
  Files                         ?      122           
  Lines                         ?     2286           
  Branches                      ?      655           
=====================================================
  Hits                          ?     1963           
  Misses                        ?      310           
  Partials                      ?       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mubbsharanwar mubbsharanwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, good with some queries.

src/recommendations/ProductCard/index.jsx Outdated Show resolved Hide resolved
src/recommendations/RecommendationsList.jsx Show resolved Hide resolved
src/recommendations/RecommendationsPage.jsx Show resolved Hide resolved
src/recommendations/RecommendationsPage.jsx Outdated Show resolved Hide resolved
@syedsajjadkazmii syedsajjadkazmii merged commit 771c288 into recommendations-v2 Aug 17, 2023
6 checks passed
@syedsajjadkazmii syedsajjadkazmii deleted the sajjad/VAN-1598 branch August 17, 2023 07:33
ahtesham-quraish pushed a commit that referenced this pull request Aug 22, 2023
mubbsharanwar pushed a commit that referenced this pull request Aug 28, 2023
zainab-amir pushed a commit that referenced this pull request Sep 7, 2023
zainab-amir pushed a commit that referenced this pull request Sep 7, 2023
syedsajjadkazmii added a commit that referenced this pull request Sep 8, 2023
* feat: add personalized recommendations (#1024)

* use Algolia for personalized recommendations
* show personalized recommendations to use that have consented
to functional cookies
* update tests

VAN-1599

* Revert "fix: special characters in redirect url getting decoded to space (#1029)" (#1030)

This reverts commit fc62241.

* feat: update recommendations page design (#1036)

VAN-1598

* feat: add events for recommendations (#1039)

* feat: remove static recommendations

---------

Co-authored-by: Syed Sajjad Hussain Shah <52817156+syedsajjadkazmii@users.noreply.github.com>
snglth pushed a commit to Abstract-Tech/community-theme-authn that referenced this pull request Jan 9, 2024
* feat: add personalized recommendations (openedx#1024)

* use Algolia for personalized recommendations
* show personalized recommendations to use that have consented
to functional cookies
* update tests

VAN-1599

* Revert "fix: special characters in redirect url getting decoded to space (openedx#1029)" (openedx#1030)

This reverts commit fc62241.

* feat: update recommendations page design (openedx#1036)

VAN-1598

* feat: add events for recommendations (openedx#1039)

* feat: remove static recommendations

---------

Co-authored-by: Syed Sajjad Hussain Shah <52817156+syedsajjadkazmii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants