fix: retain query params in authenticated user redirection #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdullahwaheed
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Retain query params in authenticated user redirection. The query params were not retained while redirecting the users to dashboard thus causing issues with enrollment flow.
Screenshots/sandbox (optional):
Before:
The enrollment URL for authn MFE is hit and the user is redirected to the dashboard instead of the enrollment page.
Screen.Recording.2024-07-18.at.4.57.05.PM.mov
After:
The enrollment URL for authn MFE is hit and the user is successfully redirected to the enrollment page.
Screen.Recording.2024-07-18.at.4.56.25.PM.mov
Merge Checklist
Post-merge Checklist