-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade react router to v6 #122
Conversation
…ns into Ali-Abbas/react-router-upgrade
Hi @Syed-Ali-Abbas-Zaidi -- this PR has been a draft for a few months now. Is there still work left to do? Can we close this? Thanks for any information on the status of the PR. If the conflicts are fixed up we can work to prioritize a review of the PR. |
Hi @justinhynes, This PR will be ready for review once the router upgrade PR of frontend-platform gets merged. |
Hi! [curious] @Syed-Ali-Abbas-Zaidi, how can I test this in parallel with the [dependency PR]? I've tested it and did't work for me |
…ns into Ali-Abbas/react-router-upgrade
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #122 +/- ##
=======================================
Coverage 83.01% 83.01%
=======================================
Files 46 46
Lines 683 683
Branches 132 132
=======================================
Hits 567 567
Misses 116 116
☔ View full report in Codecov by Sentry. |
0efe21d
to
f6c8cfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR LGTM
Ticket
React Router Upgrade to v6.
Description
This PR upgrades React Router from
v5
tov6
.