fix: post editor breaking for moderator #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: updated unit tests fix: updated unit tests
AhtishamShahid
force-pushed
the
ahtisham/INF-1424
branch
from
14e3f30
to
2935b99
Compare
AhtishamShahid
requested review from
sundasnoreen12,
ayesha-waris and
awais-ansari
awais-ansari
approved these changes
Jun 13, 2024
ayesha-waris
approved these changes
Jun 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #717 +/- ##
=======================================
Coverage 92.86% 92.87%
=======================================
Files 160 160
Lines 3322 3324 +2
Branches 888 898 +10
=======================================
+ Hits 3085 3087 +2
+ Misses 219 218 -1
- Partials 18 19 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The post editor is breaking for moderators, this was caused by the API being moved to v2 but due to implementation, 2 different APIs were using the same base URL method, which caused conflict in APIs.
This issue is fixed by setting 2 different API URL methods.
How Has This Been Tested?
Tested with Staff, Moderator, and Learner role.