Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [FC-0006] verifiable credentials feature backport to Palm #169

Conversation

GlugovGrGlib
Copy link
Member

@GlugovGrGlib GlugovGrGlib commented Aug 1, 2023

This PR is backport for Verifiable credentials functionality into open-release/palm.master

Credentials repository backport: openedx/credentials#2110
Configuration repository backport: openedx-unsupported/configuration#6971

Verifiable Credentails documentation: https://edx-credentials.readthedocs.io/en/latest/verifiable_credentials/overview.html

wowkalucky and others added 2 commits August 1, 2023 23:35
)

* feat: [FC-0006] add Verifiable Credentials optional feature

---------

Co-authored-by: Jason Wesson <jsnwesson@gmail.com>
…nedx#164)

* fix: [OeX_Cred-810] verifiable credentials QR code modal instructions

* fix: [FC-0006] update user instructions

Make user instructions more clear

---------

Co-authored-by: Glib Glugovskiy <glugov1998@gmail.com>
@GlugovGrGlib GlugovGrGlib changed the title feat: [FC-0006] verifiable credentials feature backport feat: [FC-0006] verifiable credentials feature backport to Palm Aug 1, 2023
Copy link
Contributor

@wowkalucky wowkalucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 3, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @GlugovGrGlib! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Aug 7, 2023
@GlugovGrGlib GlugovGrGlib merged commit 458fcb6 into openedx:open-release/palm.master Aug 9, 2023
3 checks passed
@openedx-webhooks
Copy link

@GlugovGrGlib 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@GlugovGrGlib GlugovGrGlib deleted the feat/verifiable_credentials_backport branch August 23, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants