feat: update react & react-dom to v17 #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #882 +/- ##
==========================================
+ Coverage 67.06% 67.09% +0.03%
==========================================
Files 128 128
Lines 3206 3206
Branches 934 934
==========================================
+ Hits 2150 2151 +1
+ Misses 1007 1006 -1
Partials 49 49 ☔ View full report in Codecov by Sentry. |
Ali-D-Akbar
approved these changes
Aug 1, 2023
|
@Ali-D-Akbar could you please merge this as well, we do not have access. |
DawoudSheraz
reviewed
Aug 2, 2023
| @@ -162,7 +162,6 @@ exports[`CreateCoursePage renders page correctly with course create error 1`] = | |||
| "timeout": 300, | |||
| "unmountOnExit": false, | |||
| }, | |||
| "displayName": "Fade", | |||
There was a problem hiding this comment.
any ideas why this attr has been removed from various snapsots?
There was a problem hiding this comment.
Snapshots are updating when we update the @edx/paragon version from 20.39.3 to 20.40.0.
DawoudSheraz
approved these changes
Aug 23, 2023
Mashal-m
force-pushed
the
mashal-m/react-upgrade-to-v17
branch
from
44606ed
to
c7e647a
Compare
zawan-ila
added a commit
to zawan-ila/frontend-app-publisher
that referenced
this pull request
Oct 4, 2023
This reverts commit 92095ef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Upgrade React JS to v17
Description
react&react-domto v17, along with@tinymce/tinymce-reactto respective compatible versionsenzyme-adapter-react-16with@wojtekmaj/enzyme-adapter-react-17@edx/frontend-platform, @edx/frontend-component-footer-edx