feat: updated frontend-build & frontend-platform major versions #475
Conversation
…ontent-components into bilalqamar95/jest-v29-upgrade
|
Hey, are there any blockers on merging this? |
@bradenmacdonald no blockers, the PR is ready to be reviewed/merge |
…ontent-components into bilalqamar95/jest-v29-upgrade
…ai-translations
to support frontend-build v14
Depends on:
openedx/frontend-lib-content-components#475
openedx-unsupported/frontend-component-ai-translations#16
Commands used:
npm install "git+https://github.com/open-craft/frontend-lib-content-components.git#jill/bilalqamar95/jest-v29-upgrade"
npm install "git+https://github.com/open-craft/frontend-component-ai-translations.git#jill/frontend-platform-v8"
…ai-translations
to support frontend-build v14
Depends on:
openedx/frontend-lib-content-components#475
openedx-unsupported/frontend-component-ai-translations#16
Commands used:
npm install "git+https://github.com/open-craft/frontend-lib-content-components.git#jill/bilalqamar95/jest-v29-upgrade"
npm install "git+https://github.com/open-craft/frontend-component-ai-translations.git#jill/frontend-platform-v8"
There was a problem hiding this comment.
👍 Thanks for incorporating that prepare change @BilalQamar95 :)
This change is working great for course authoring (openedx/frontend-app-authoring#1052), but I can't speak for the other MFEs.
- I tested this by using this branch on Upgrade frontend-build to v14 frontend-app-authoring#1052
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate during testing.
-
Includes documentationN/A -
User-facing strings are extracted for translationN/A
|
@BilalQamar95 Do you think you'll be able to get this PR reviewed+merged this week? We have a few PRs building up that depend on this change, so I'm hoping we can use it ASAP. Thanks for your work on this :) |
|
@rayzhou-bit I see that you are testing this on hosted devstack, maybe you can provide more details which can help trace the issue. For now both me and my colleague tested this locally & faced no issues. |
There was a problem hiding this comment.
@BilalQamar95 Looks like something was up with my devstack. I reset my frontend-app-course-authoring and frontend-lib-content-components repos and was able to do some studio testing. The change looks good to me!
|
@rayzhou-bit can you please merge this as well? I'm unable to do so since I do not have write access to this repository |
|
Thank you for merging this @rayzhou-bit @BilalQamar95 ! |
Description
frontend-buildto v14 &frontend-platformto v8 along with respective edx packagessnapshotsfor failing tests