build: Shifted CI from Travis to GitHub Actions #194
Conversation
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
=========================================
Coverage ? 95.01%
=========================================
Files ? 29
Lines ? 2788
Branches ? 209
=========================================
Hits ? 2649
Misses ? 113
Partials ? 26
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@Jawayria I have gone to this page: Also, it'd be preferable to have newlines at the end of each file in this PR. |
Jawayria
force-pushed
the
jawayria/github-ci
branch
from
fd819d5
to
52af5e2
Compare
|
@doctoryes it seems like Travis CI checks are still required. I don't have access to this repo's settings. Can you please have a look at it. |
|
Closing/re-opening to trigger tests. |
|
@Jawayria I've turned back on the TravisCI runs. Perhaps you need to force-push to your branch again to kick off the TravisCI for your branch? |
.github/workflows/pypi-publish.yml
Outdated
| run: pip install -r requirements/pip.txt | ||
|
|
||
| - name: Install Dependencies | ||
| run: pip install setuptools wheel |
There was a problem hiding this comment.
we don't need this, since all of these packages should already be listed in pip.txt
|
|
||
| coveralls # Code coverage reporting | ||
| tox # Virtualenv management for tests | ||
| tox-battery # Makes tox aware of requirements file changes |
There was a problem hiding this comment.
do we really need tox-battery?
There was a problem hiding this comment.
I don't think so but it was being used with travis as well.
.github/workflows/pypi-publish.yml
Outdated
| uses: pypa/gh-action-pypi-publish@master | ||
| with: | ||
| user: __token__ | ||
| password: ${{ secrets.PYPI_UPLOAD_TOKEN }} |
There was a problem hiding this comment.
file should end with a newline
.github/workflows/ci.yml
Outdated
| uses: codecov/codecov-action@v1 | ||
| with: | ||
| flags: unittests | ||
| fail_ci_if_error: true |
There was a problem hiding this comment.
file should end with a newline
requirements/pip.in
Outdated
|
|
||
| pip | ||
| setuptools | ||
| wheel |
kdmccormick
force-pushed
the
jawayria/github-ci
branch
from
5d92639
to
a0ccc28
Compare
kdmccormick
changed the title
|
Thanks @Jawayria . I rebased this branch and will merge it soon. After it's merged, I'll remove Travis CI from this repo. |
This is a part of Django 3.2 upgrade process as mentioned in this doc Django 3.2 Upgrade: Steps to Upgrade a Repository