feat: [FC-0047] Relative Dates #367
Conversation
|
Thanks for the pull request, @PavloNetrebchuk! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
PavloNetrebchuk
force-pushed
the
feat/relative_dates
branch
from
88ac501
to
f001577
Compare
PavloNetrebchuk
force-pushed
the
feat/relative_dates
branch
from
f001577
to
01118a6
Compare
|
HI @PavloNetrebchuk, this looks almost all good from the design side. For upcoming dates within the There are a lot of edge cases here, so I did my best to document them in the Figma file below the Dates section: https://www.figma.com/design/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.2?node-id=6703-32751&t=vxtbWParuRUmfgkZ-4 Here are the cases documented there for reference: Sections & date formats (items appear once, in the first case they meet)
|
|
@sdaitzman
|
|
Hi @PavloNetrebchuk, thank you for making these updates. I think this is all clear from the design side for now. In the future, I think it's worth coming back to this and reconsidering how we approach dates/examining some edge cases, so I've created a new roadmap issue (#370) to track that future work. |
PavloNetrebchuk
force-pushed
the
feat/relative_dates
branch
2 times, most recently
from
2db038d
to
db4e41f
Compare
PavloNetrebchuk
force-pushed
the
feat/relative_dates
branch
from
db4e41f
to
9b46679
Compare
volodymyr-chekyrta
requested review from
k1rill,
dixidroid,
omerhabib26 and
HamzaIsrar12
…relative_dates # Conflicts: # app/src/main/java/org/openedx/app/di/ScreenModule.kt # core/src/main/java/org/openedx/core/extension/StringExt.kt # course/src/main/java/org/openedx/course/presentation/videos/CourseVideoViewModel.kt # course/src/test/java/org/openedx/course/presentation/outline/CourseOutlineViewModelTest.kt # course/src/test/java/org/openedx/course/presentation/videos/CourseVideoViewModelTest.kt # dashboard/src/main/java/org/openedx/courses/presentation/AllEnrolledCoursesView.kt # dashboard/src/main/java/org/openedx/courses/presentation/DashboardGalleryView.kt # dashboard/src/main/java/org/openedx/dashboard/presentation/DashboardListFragment.kt # discovery/src/main/java/org/openedx/discovery/presentation/ui/DiscoveryUI.kt
Added a switch that enables showing relative dates on the initial calendar screen and the calendar settings screen.
The
isRelativeDatesEnabledfunctionality has been added to improve the readability of dates within the application. When this feature is enabled (default setting), dates within the range of -7 to +7 days from the current date will be displayed in a relative format (e.g., “just now,” “2 days ago”). Dates outside this range will continue to be displayed in the traditional format. This setting can be toggled in the calendar synchronization settings. The feature is enabled by default.Environment for testing: