fix: bootstrap update with additional variable #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## master #1562 +/- ##
=======================================
Coverage 91.46% 91.46%
=======================================
Files 206 206
Lines 3490 3490
Branches 818 818
=======================================
Hits 3192 3192
Misses 283 283
Partials 15 15 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
adamstankiewicz
approved these changes
Aug 16, 2022
edx-semantic-release
pushed a commit
that referenced
this pull request
Aug 16, 2022
## [20.9.2](v20.9.1...v20.9.2) (2022-08-16) ### Bug Fixes * bootstrap update with additional variable ([#1562](#1562)) ([ae1f06f](ae1f06f))
|
🎉 This PR is included in version 20.9.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
pshiu
added a commit
to openedx/frontend-app-payment
that referenced
this pull request
Aug 22, 2022
Newer versions of Bootstrap cause the following error in
frontend-app-payment:
ERROR in ./example/index.scss (./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[1].use[1]!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].use[2]!./node_modules/resolve-url-loader/index.js!./node_modules/sass-loader/dist/cjs.js??ruleSet[1].rules[1].use[4]!./example/index.scss)
Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: Undefined variable.
╷
24 │ @include transition($transition-collapse-width);
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
node_modules/bootstrap/scss/_transitions.scss 24:25 @import
node_modules/@edx/paragon/scss/core/core.scss 8:9 @import
example/index.scss 3:9 root stylesheet
This has been fixed in Paragon 20.9.2. See
openedx/paragon#1562. But we cannot upgrade to
that version of Paragon yet due to a bug in how we use <Dropdown.Toggle>
in frontend-component-header-edx. See previous commit for more details.
pshiu
added a commit
to openedx/frontend-app-payment
that referenced
this pull request
Aug 23, 2022
Newer versions of Bootstrap cause the following error in
frontend-app-payment:
ERROR in ./example/index.scss (./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[1].use[1]!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].use[2]!./node_modules/resolve-url-loader/index.js!./node_modules/sass-loader/dist/cjs.js??ruleSet[1].rules[1].use[4]!./example/index.scss)
Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: Undefined variable.
╷
24 │ @include transition($transition-collapse-width);
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
node_modules/bootstrap/scss/_transitions.scss 24:25 @import
node_modules/@edx/paragon/scss/core/core.scss 8:9 @import
example/index.scss 3:9 root stylesheet
This has been fixed in Paragon 20.9.2. See
openedx/paragon#1562. But we cannot upgrade to
that version of Paragon yet due to a bug in how we use <Dropdown.Toggle>
in frontend-component-header-edx. See previous commit for more details.
ghassanmas
added a commit
to ghassanmas/frontend-app-account
that referenced
this pull request
Sep 6, 2022
Bootsrap 4.6.2 cause build to fail due to missing variable: ref: openedx/paragon/pull/1562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TLDR; update bootstrap scss version to fix
core.scssissueBootstrap 4.6.1 doesn't have
$transition-collapse-widthvariable in the scss. Sincepackage.jsonusebootstrap: ^4.6.1, any project that usedparagonwill try to install4.6.2. Hence this issue #1559Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
exampleapp?wittjeffandadamstankiewiczas reviewers on this PR.Post-merge Checklist