-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] feat: defined types for Paragon export #2566
base: master
Are you sure you want to change the base?
[BD-46] feat: defined types for Paragon export #2566
Conversation
…, Popover components
Thanks for the pull request, @monteri! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2566 +/- ##
==========================================
+ Coverage 91.65% 91.69% +0.03%
==========================================
Files 236 236
Lines 4195 4227 +32
Branches 1012 1022 +10
==========================================
+ Hits 3845 3876 +31
- Misses 346 347 +1
Partials 4 4
☔ View full report in Codecov by Sentry. |
I'm really happy to see this PR! I can help test/review if you like - let me know how I can help. I have a couple questions:
|
@bradenmacdonald Thank you for paying attention to this PR.
|
@PKulkoRaccoonGang Thanks for the details! @PKulkoRaccoonGang @adamstankiewicz What do you think about splitting this up into smaller PRs and trying to get them merged separately? I think we should really try to make at least the tests and the documentation site consume the TypeScript types, so that we have some way of checking that they're used and in sync. Here's an example of what I mean: #3016 (I noticed that this PR doesn't include types for the |
Description
Define types for Paragon exports
Issue: #1964
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist