Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] fix: hover for danger button #2675

Closed

Conversation

khudym
Copy link
Contributor

@khudym khudym commented Sep 29, 2023

Description

add hover styles for dark button
Issue

Deploy Preview

Deploy Preview

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Sep 29, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @khudym!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4e94cdc
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/651fdb2fbc310800089b95ee
😎 Deploy Preview https://deploy-preview-2675--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b081084) 91.90% compared to head (4e94cdc) 91.83%.
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2675      +/-   ##
==========================================
- Coverage   91.90%   91.83%   -0.08%     
==========================================
  Files         235      235              
  Lines        4310     4224      -86     
  Branches     1044     1024      -20     
==========================================
- Hits         3961     3879      -82     
+ Misses        345      341       -4     
  Partials        4        4              

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viktorrusakov viktorrusakov linked an issue Oct 2, 2023 that may be closed by this pull request

&:hover {
.btn-brand {
background: map-get($search-btn-variants, "dark");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this fixes the issue, the color still does not change on hover for the dark variant
image

it should change to this color (taken from the Buttons page of the docs site)
image

@viktorrusakov
Copy link
Contributor

Ideally, we should be able to just re-use the buttons without overriding their styles in SearchField. Maybe we have some redundant styles in SearchField which we can remove and the issue will get fixed?

Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link the changes that concern the brand-edx-org

@brian-smith-tcril
Copy link
Contributor

I just tested this with the edX theme on the deploy preview and it doesn't seem to be working

button

@viktorrusakov
Copy link
Contributor

@brian-smith-tcril Yeah, it has to be merged together with edx/brand-edx.org#77 for the edX brand theme to work, this is our concern with this PR, that consumers will need to update versions of both packages for the fix to work.

@khudym khudym closed this Nov 23, 2023
@openedx-webhooks
Copy link

@khudym Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@khudym
Copy link
Contributor Author

khudym commented Nov 23, 2023

We plan to release all breaking changes at the same time, a new PR is open #2844

@khudym khudym mentioned this pull request Nov 23, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

SearchField.SubmitButton with variant="dark" has no hover styles
5 participants