-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] fix: hover for danger button #2675
Conversation
Thanks for the pull request, @khudym! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2675 +/- ##
==========================================
- Coverage 91.90% 91.83% -0.08%
==========================================
Files 235 235
Lines 4310 4224 -86
Branches 1044 1024 -20
==========================================
- Hits 3961 3879 -82
+ Misses 345 341 -4
Partials 4 4 ☔ View full report in Codecov by Sentry. |
src/SearchField/index.scss
Outdated
|
||
&:hover { | ||
.btn-brand { | ||
background: map-get($search-btn-variants, "dark"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, we should be able to just re-use the buttons without overriding their styles in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please link the changes that concern the brand-edx-org
@brian-smith-tcril Yeah, it has to be merged together with edx/brand-edx.org#77 for the edX brand theme to work, this is our concern with this PR, that consumers will need to update versions of both packages for the fix to work. |
@khudym Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
We plan to release all breaking changes at the same time, a new PR is open #2844 |
Description
add hover styles for dark button
Issue
Deploy Preview
Deploy Preview
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist