Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(greenkeeper): greenkeeper incompatible with npm ci, use npm install #307

Merged
merged 1 commit into from
Aug 3, 2018

Conversation

MichaelRoytman
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.552% when pulling f91a9f7 on mroytman/fix-greenkeeper-npm-ci into 43cbdd9 on master.

@MichaelRoytman
Copy link
Contributor Author

Per this documentation,

npm ci won't work with greenkeeper pull requests because:
If dependencies in the package lock do not match those in package.json, npm ci will exit with an error, instead of updating the package lock.

Travis will use npm ci by default if lockfiles are present so you'll need to explicitly tell your CI to run npm install instead of npm ci

Greenkeeper is aware of the issue, it seems, and at the time of this comment, recommended using npm install instead of Travis's default npm ci. This may have been fixed in their 2.0.0 release, but I haven't verified that, and it's not their latest release. I believe it's still being tested.

I have changed .travis.yml to use npm install instead, but we lose some of the benefits of npm ci. Below, there are two example PRs that demonstrate that this fixes the issue.

#300
#299

Copy link
Contributor

@georgebabey georgebabey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Looks good - thanks Michael!

@MichaelRoytman MichaelRoytman merged commit ad3b47e into master Aug 3, 2018
@MichaelRoytman MichaelRoytman deleted the mroytman/fix-greenkeeper-npm-ci branch August 3, 2018 13:12
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 3.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants