Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: [BD-46] Updated Design tokens and Style dictionary documentation #3075

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented May 16, 2024

Description

Updated Design tokens and Style dictionary documentation

Preview

0018-design-tokens-style-dictionary

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label May 16, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented May 16, 2024

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

Copy link

netlify bot commented May 16, 2024

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6fe50e5
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6645ff2424b00d0008ba44ef
😎 Deploy Preview https://deploy-preview-3075--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.68%. Comparing base (a2b552c) to head (9b26035).

❗ Current head 9b26035 differs from pull request most recent head 6fe50e5. Consider uploading reports for the commit 6fe50e5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #3075   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files         229      229           
  Lines        3740     3740           
  Branches      876      903   +27     
=======================================
  Hits         3504     3504           
  Misses        232      232           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/add-decisions-doc-for-design-tokens branch 3 times, most recently from bde89f7 to c55cd57 Compare May 16, 2024 12:00
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft May 16, 2024 12:01
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/add-decisions-doc-for-design-tokens branch from c55cd57 to 9b26035 Compare May 16, 2024 12:22
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/add-decisions-doc-for-design-tokens branch from 9b26035 to 6fe50e5 Compare May 16, 2024 12:42
@PKulkoRaccoonGang PKulkoRaccoonGang self-assigned this May 16, 2024
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review May 16, 2024 12:44
@brian-smith-tcril brian-smith-tcril merged commit 651632f into openedx:alpha May 21, 2024
8 checks passed
@openedx-semantic-release-bot

🎉 This PR is included in version 23.0.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants