Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: successfully merge refs in Input #458

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

abutterworth
Copy link
Contributor

Supplying a ref to an Input component no longer errors out in development. This is a better strategy at "merging" refs inspired by this thread: facebook/react#13029 (comment)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 88.482% when pulling ef0fd59 on abutterworth/fix-input-ref into 0186104 on master.

Copy link
Contributor

@matthugs matthugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a good amount of blinking at this to understand it. But yes, makes sense.

@abutterworth abutterworth merged commit 420e52d into master Jun 6, 2019
@abutterworth abutterworth deleted the abutterworth/fix-input-ref branch June 6, 2019 20:28
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 4.2.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants