-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: encode the csv data before save #100
fix: encode the csv data before save #100
Conversation
Thanks for the pull request, @arslanashraf7! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@arslanashraf7 Thank you for your contribution. Is this ready for our review? |
@natabene Yes, it's ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
740b7c7
to
5c57abe
Compare
@arslanashraf7 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description: Describe in a couple of sentences what this PR adds
This PR adds python's default(
utf-8
) encoding on the file data before saving.This is not needed in the case of local storage while manipulating the grades but it becomes an issue when we use AWS/S3 storage as a backend instead of the local storage. The s3 services throw errors about file encoding.
A sample error log is attached below.
JIRA: Link to JIRA ticket
More details can be seen on mitodl/mitxonline#415
Dependencies: dependencies on other outstanding PRs, issues, etc.
None
Merge deadline: List merge deadline (if any)
No Specific Date but Soon
Installation instructions: List any non-trivial installation
instructions.
Testing instructions:
Mentioned in mitodl/mitxonline#415
Sample Error Log
The sample error log can be seen:
Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.