-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared Github Action workflow for semantic-release
dry-run to preview next version on PRs
#139
Comments
Following are some of the observations I came across while working on this issue:
Verdict: cc: @adamstankiewicz |
@ishahroz Great investigation! An officially supported solution to this problem seems like its desired by the community; it'd be fantastic if there was an official solution. The primary goal of this is to help PR authors aware of the next version to be released, not so much previewing release notes, etc. I'd say the release notes preview specifically is a nice-to-have, where only the next version to be released is a must. It seems that the last suggestion could be worth exploring to see if we could get it to work. Should we try enabling it in Paragon and/or any other repos? I'm not too concerned around the creating/updating comments on the PR with this solution because I believe we have some prior art for how to manage such behavior. |
+1 for @ishahroz, have you been able to test it already? |
@abdullahwaheed, checking status: it looks like this was set to blocked. Care to give us a short update? What is this blocked on? |
Hey, I have explored this package, but there's no luck when it comes to triggering dry runs within PR. I have asked the owner of this package, and here is what he replied. |
It seems like Any objections to following this particular suggestion (the one based on |
Hey @arbrandes, I have tried this suggestion as well, but it is not helping either. |
@Mashal-m, have there been any findings since last August? Do we want to continue pursuing this? |
Most of our JS repos use
semantic-release
to release to NPM, which handles semantic versioning based on commit types. While the rest of the non-JS repos have also conformed to standard commit types (e.g.,feat
,fix
, etc.), only a small subset of commit types will actually trigger a release to NPM:fix
feat
perf
Any other commit types (e.g.,
chore
) does not trigger an NPM release with the defaultsemantic-release
configuration. This makes sense, though, as not every commit should trigger a release.That said, it would be helpful for our JS repos to have a way to indicate to engineers who author/review PRs which version, if any, will be released by
semantic-release
based on the commit type(s) used in the branch. This would give an extra sanity check to ensure merging a PR will have the intended outcome regarding NPM releases.Some repos have attempted to include a step in their CI workflows to output the results from a dry-run of
semantic-release
.frontend-enterprise
(source), though this is a monorepo managed by Lerna, which usessemantic-release
behind-the-scenes.paragon
(source), using vanillasemantic-release
. Results in the following error:This run was triggered by a pull request and therefore a new version won't be published.
AC
semantic-release
to preview what version (if any) would be released after merging a given PR.semantic-release
(intentionally not includefrontend-enterprise
here because it uses Lerna and has a working solution already). Sampling of repos:@edx/frontend-build
@edx/frontend-platform
@edx/paragon
@edx/browserslist-config
@edx/frontend-component-header
@edx/frontend-component-header-edx
@edx/frontend-component-footer
@edx/frontend-component-footer-edx
The text was updated successfully, but these errors were encountered: