Convert ansible to dockerfile #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #863 +/- ##
=======================================
Coverage 84.82% 84.82%
=======================================
Files 14 14
Lines 659 659
=======================================
Hits 559 559
Misses 100 100 ☔ View full report in Codecov by Sentry. |
mumarkhan999
force-pushed
the
umar/ansible-to-docker
branch
2 times, most recently
from
555a3b5
to
1c25005
Compare
mumarkhan999
force-pushed
the
umar/ansible-to-docker
branch
from
f03a114
to
35ef927
Compare
iamsobanjaved
requested changes
Feb 14, 2023
iamsobanjaved
force-pushed
the
umar/ansible-to-docker
branch
from
265e314
to
414561a
Compare
iamsobanjaved
force-pushed
the
umar/ansible-to-docker
branch
from
414561a
to
545f036
Compare
iamsobanjaved
approved these changes
Apr 11, 2023
iamsobanjaved
added a commit
that referenced
this pull request
May 2, 2023
* feat: Convert ansible to dockerfile * feat: add workflow to publish docker images --------- Co-authored-by: Soban Javed <iamsobanjaved@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related devstack PR: openedx-unsupported/devstack#1006
ISSUE: #861
This PR is part of an effort aimed at removing Ansible-based configurations and replacing them with
Dockerfile. Currently, Devstack Docker images are built usingAnsible-based configurationsin theconfigurationsrepository. Through this effort, we will make sure that the Repo has its ownDockerfilewhich has all the necessary configurations to set up small production and dev environments.Steps to run this Image with Devstack:
devi.e.docker build -t image-name-of-choice --target dev .docker composefile ofdevstackand replace the existingxqueueimage with the one that you built without changing any other configurations there.make dev.up.xqueuein the terminal while in the devstack directory.xqueue