feat: Nationality list refactor for uniqueness and refactor nationality layout for new list #6936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor list for uniqueness remove old pre production list refactor nationaliy layout for new list
bradymiller
reviewed
Oct 17, 2023
sql/7_0_1-to-7_0_2_upgrade.sql
Outdated
| #IfMissingColumn patient_data nationality_country | ||
| ALTER TABLE `patient_data` ADD `nationality_country` TINYTEXT; | ||
| #EndIf |
There was a problem hiding this comment.
this block was already added above
bradymiller
reviewed
Oct 17, 2023
sql/7_0_1-to-7_0_2_upgrade.sql
Outdated
| #IfRow2D list_options list_id lists option_id Nationality_and_Country | ||
| DELETE FROM `list_options` WHERE `list_id` = 'lists' AND `option_id` = 'Nationality_and_Country'; | ||
| #EndIf |
There was a problem hiding this comment.
this block was already completed above
bradymiller
reviewed
Oct 17, 2023
sql/7_0_1-to-7_0_2_upgrade.sql
Outdated
| #IfRow list_options list_id Nationality_and_Country | ||
| DELETE FROM `list_options` WHERE `list_id` LIKE 'Nationality_and_Country'; | ||
| #EndIf |
There was a problem hiding this comment.
this block was already completed above
|
@sjpadgett , just noted couple duplicate blocks in upgrade script. Otherwise looks great!
|
bradymiller
reviewed
Oct 17, 2023
sql/7_0_1-to-7_0_2_upgrade.sql
Outdated
| #EndIf | ||
|
|
||
| #IfRow2D layout_options form_id DEM field_id nationality_country |
There was a problem hiding this comment.
actually to be safe here (only ensure it runs once and doesn't overwrite future customizations), would do:
#IfRow3D layout_options form_id DEM field_id nationality_country list_id Nationality_and_Country
|
|
adunsulag
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Short description of what this resolves:
refactor list for uniqueness
remove old pre production list
refactor nationality layout for new list