Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV meter upload validates values #1217

Open
huss opened this issue Apr 9, 2024 · 9 comments
Open

CSV meter upload validates values #1217

huss opened this issue Apr 9, 2024 · 9 comments
Labels
p-low-priority t-enhancement This issues tracks a potential improvement to the software
Milestone

Comments

@huss
Copy link
Member

huss commented Apr 9, 2024

Is your feature request related to a problem? Please describe.

The create meter page stops admins from entering bad values by constraining choices and/or checking before saving. It would be good if the CSV meter upload page did similar checks.

Describe the solution you'd like

See above.

Describe alternatives you've considered

No checking

Additional context

None

@huss huss added t-enhancement This issues tracks a potential improvement to the software p-low-priority labels Apr 9, 2024
@huss huss added this to the 1.x milestone Apr 9, 2024
@mikedivine
Copy link
Contributor

I will work on this issue.

@ethanernst11
Copy link

I can work on this issue.

@huss
Copy link
Member Author

huss commented Oct 18, 2024

I can work on this issue.

I think this is okay since @mikedivine is not working on this at this time. If you need any help on this then let me know.

@ethanernst11
Copy link

I have a quick question. Where can I find the code for the create meter page that stops admins from entering bad values?

@huss
Copy link
Member Author

huss commented Oct 20, 2024

I have a quick question. Where can I find the code for the create meter page that stops admins from entering bad values?

See src/client/app/components/meters/CreateMeterModalComponent.tsx (there is an edit equivalent). There are a number of checks here that are done in different ways (different ways is not needed for this issue). As examples, it validates GPS, can't have cumulative reset if not cumulative, set identifier if name given, no blank name, .... Let me know if you need anything else.

@ethanernst11
Copy link

Is the csv meter upload also creating a meter?

@huss
Copy link
Member Author

huss commented Oct 22, 2024

Is the csv meter upload also creating a meter?

In general, the CSV meter upload creates meter(s). It is possible to edit a single meter but that is less common. If you have not seen it yet, you may find the documentation at https://openenergydashboard.org/helpV1_0_0/adminCsvImport/ useful. It is for v1.0.0 so is a little out of date with development but still useful.

@ethanernst11
Copy link

I apologize but this ended up being more complicated than expected and I do not have enough time currently to work on it. So I will not be able to continue working on this issue for finish it. I am sorry for any inconvenience.

@huss
Copy link
Member Author

huss commented Oct 24, 2024

I apologize but this ended up being more complicated than expected and I do not have enough time currently to work on it. So I will not be able to continue working on this issue for finish it. I am sorry for any inconvenience.

It's fine and thanks for letting us know. If you want to work on something in the future then please just let us know (and we can help find a task that suits your situation if that helps).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-low-priority t-enhancement This issues tracks a potential improvement to the software
Projects
None yet
Development

No branches or pull requests

3 participants