Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make conversion menus dynamic #904

Closed
huss opened this issue May 20, 2023 · 1 comment · Fixed by #1018
Closed

make conversion menus dynamic #904

huss opened this issue May 20, 2023 · 1 comment · Fixed by #1018
Assignees
Labels
p-medium-priority t-enhancement This issues tracks a potential improvement to the software
Milestone

Comments

@huss
Copy link
Member

huss commented May 20, 2023

Is your feature request related to a problem? Please describe.

The conversion create page checks for a number of undesirable conditions. Most of the modal pages have React hooks to dynamically change the menus so the admin cannot make that selection. For example, once a source or destination is selected then it should be removed from the other menu. Another example is not allowing meter units to be a destination (this one is static).

Describe the solution you'd like

Make the conversion menus use React hooks and modify menus as needed.

Describe alternatives you've considered

The current fix of testing after selection. Many can be removed if this is done.

Additional context

None

@huss huss added t-enhancement This issues tracks a potential improvement to the software p-medium-priority labels May 20, 2023
@huss huss added this to the 1.1 release milestone May 20, 2023
@qnhn22
Copy link
Contributor

qnhn22 commented Sep 19, 2023

I would like to work on this issue. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-medium-priority t-enhancement This issues tracks a potential improvement to the software
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants