Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meter units should have displayable of none #907

Closed
huss opened this issue May 20, 2023 · 0 comments · Fixed by #958
Closed

meter units should have displayable of none #907

huss opened this issue May 20, 2023 · 0 comments · Fixed by #958
Assignees
Labels
assigned the issue is currently being worked on by a developer

Comments

@huss
Copy link
Member

huss commented May 20, 2023

Is your feature request related to a problem? Please describe.

Meter units are not visible on graphic menus so they are effectively displayable of none. Currently the admin can set it to another value during creation/editing. It would be nice to stop changes once the unit is of type meter. If there already is a displayable other than none then the admin should be warned and the value changed to none.

Describe the solution you'd like

See above.

Describe alternatives you've considered

This is only confusing and the change does not change how OED works. Thus, the current situation could stay so this is a lower priority.

Additional context

None

spearec added a commit to spearec/OED that referenced this issue Jul 26, 2023
- Various help tooltips move to be inline
- Fixed OpenEnergyDashboard#907, preventing admins from setting meter units to be displayable
@spearec spearec self-assigned this Jul 27, 2023
@spearec spearec added the assigned the issue is currently being worked on by a developer label Jul 27, 2023
@huss huss closed this as completed in #958 Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned the issue is currently being worked on by a developer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants