This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Send value & contract execute gas limit warnings #3512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 8d339ad on jg-transact-gas-warnings into * on master*. |
|
Changes Unknown when pulling f827ade on jg-transact-gas-warnings into * on master*. |
ngotchac
reviewed
Nov 22, 2016
| // You should have received a copy of the GNU General Public License | ||
| // along with Parity. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| const DEFAULT_GAS = '21000'; |
There was a problem hiding this comment.
Are these values always fixed, for any network?
There was a problem hiding this comment.
For a account -> account transfer, it is always 21k. (We never directly use this value, any gas passed is always from estimations, so even when we know it is 21k, we still call estimateGas and use that value. Worst-case it is a placeholder until the first call to estimateGas)
ngotchac
added
A6-mustntgrumble 💦
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show gas block limit exceeded & transaction execution failures warnings.
Closes https://github.com/ethcore/parity/issues/3366