This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
basic tests for subscribeToEvents #4115
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,115 @@ | ||
// Copyright 2015, 2016 Parity Technologies (UK) Ltd. | ||
// This file is part of Parity. | ||
|
||
// Parity is free software: you can redistribute it and/or modify | ||
// it under the terms of the GNU General Public License as published by | ||
// the Free Software Foundation, either version 3 of the License, or | ||
// (at your option) any later version. | ||
|
||
// Parity is distributed in the hope that it will be useful, | ||
// but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
// GNU General Public License for more details. | ||
|
||
// You should have received a copy of the GNU General Public License | ||
// along with Parity. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
import { spy, stub } from 'sinon'; | ||
|
||
import subscribeToEvents from './subscribe-to-events'; | ||
import { | ||
pastLogs, liveLogs, createApi, createContract | ||
} from './subscribe-to-events.test.js'; | ||
|
||
const delay = (t) => new Promise((resolve) => { | ||
setTimeout(resolve, t); | ||
}); | ||
|
||
describe('util/subscribe-to-events', () => { | ||
beforeEach(function () { | ||
this.api = createApi(); | ||
this.contract = createContract(this.api); | ||
}); | ||
|
||
it('installs a filter', async function () { | ||
const { api, contract } = this; | ||
|
||
subscribeToEvents(contract, [ 'Foo', 'Bar' ]); | ||
await delay(0); | ||
|
||
expect(api.eth.newFilter.calledOnce).to.equal(true); | ||
expect(api.eth.newFilter.firstCall.args).to.eql([ { | ||
fromBlock: 0, toBlock: 'latest', | ||
address: contract.address, | ||
topics: [ [ | ||
contract.instance.Foo.signature, | ||
contract.instance.Bar.signature | ||
] ] | ||
} ]); | ||
}); | ||
|
||
it('queries & parses logs in the beginning', async function () { | ||
const { api, contract } = this; | ||
|
||
subscribeToEvents(contract, [ 'Foo', 'Bar' ]); | ||
|
||
await delay(0); | ||
expect(api.eth.getFilterLogs.callCount).to.equal(1); | ||
expect(api.eth.getFilterLogs.firstCall.args).to.eql([ 123 ]); | ||
|
||
await delay(0); | ||
expect(contract.parseEventLogs.callCount).to.equal(1); | ||
}); | ||
|
||
it('emits logs in the beginning', async function () { | ||
const { contract } = this; | ||
|
||
const onLog = spy(); | ||
const onFoo = spy(); | ||
const onBar = spy(); | ||
subscribeToEvents(contract, [ 'Foo', 'Bar' ]) | ||
.on('log', onLog) | ||
.on('Foo', onFoo) | ||
.on('Bar', onBar); | ||
|
||
await delay(0); | ||
|
||
expect(onLog.callCount).to.equal(2); | ||
expect(onLog.firstCall.args).to.eql([ pastLogs[0] ]); | ||
expect(onLog.secondCall.args).to.eql([ pastLogs[1] ]); | ||
expect(onFoo.callCount).to.equal(1); | ||
expect(onFoo.firstCall.args).to.eql([ pastLogs[0] ]); | ||
expect(onBar.callCount).to.equal(1); | ||
expect(onBar.firstCall.args).to.eql([ pastLogs[1] ]); | ||
}); | ||
|
||
it('uninstalls the filter on sunsubscribe', async function () { | ||
const { api, contract } = this; | ||
|
||
const s = subscribeToEvents(contract, [ 'Foo', 'Bar' ]); | ||
await delay(0); | ||
s.unsubscribe(); | ||
await delay(0); | ||
|
||
expect(api.eth.uninstallFilter.calledOnce).to.equal(true); | ||
expect(api.eth.uninstallFilter.firstCall.args).to.eql([ 123 ]); | ||
}); | ||
|
||
it('checks for new events regularly', async function () { | ||
const { api, contract } = this; | ||
api.eth.getFilterLogs = stub().resolves([]); | ||
|
||
const onLog = spy(); | ||
const onBar = spy(); | ||
const s = subscribeToEvents(contract, [ 'Bar' ], { interval: 5 }) | ||
.on('log', onLog) | ||
.on('Bar', onBar); | ||
await delay(9); | ||
s.unsubscribe(); | ||
|
||
expect(onLog.callCount).to.equal(1); | ||
expect(onLog.firstCall.args).to.eql([ liveLogs[0] ]); | ||
expect(onBar.callCount).to.equal(1); | ||
expect(onBar.firstCall.args).to.eql([ liveLogs[0] ]); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
// Copyright 2015, 2016 Parity Technologies (UK) Ltd. | ||
// This file is part of Parity. | ||
|
||
// Parity is free software: you can redistribute it and/or modify | ||
// it under the terms of the GNU General Public License as published by | ||
// the Free Software Foundation, either version 3 of the License, or | ||
// (at your option) any later version. | ||
|
||
// Parity is distributed in the hope that it will be useful, | ||
// but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
// GNU General Public License for more details. | ||
|
||
// You should have received a copy of the GNU General Public License | ||
// along with Parity. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
import { stub } from 'sinon'; | ||
|
||
export const ADDRESS = '0x1111111111111111111111111111111111111111'; | ||
|
||
export const pastLogs = [ | ||
{ event: 'Foo', type: 'mined', address: ADDRESS, params: {} }, | ||
{ event: 'Bar', type: 'mined', address: ADDRESS, params: {} } | ||
]; | ||
|
||
export const liveLogs = [ | ||
{ event: 'Bar', type: 'mined', address: ADDRESS, params: { foo: 'bar' } } | ||
]; | ||
|
||
export const createApi = () => ({ | ||
eth: { | ||
newFilter: stub().resolves(123), | ||
uninstallFilter: stub() | ||
.rejects(new Error('unknown filter id')) | ||
.withArgs(123).resolves(null), | ||
getFilterLogs: stub() | ||
.rejects(new Error('unknown filter id')) | ||
.withArgs(123).resolves(pastLogs), | ||
getFilterChanges: stub() | ||
.rejects(new Error('unknown filter id')) | ||
.withArgs(123).resolves(liveLogs) | ||
} | ||
}); | ||
|
||
export const createContract = (api) => ({ | ||
api, | ||
address: ADDRESS, | ||
instance: { | ||
Foo: { signature: 'Foo signature' }, | ||
Bar: { signature: 'Bar signature' } | ||
}, | ||
parseEventLogs: stub().returnsArg(0) | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the use of await, really do :)
However, wouldn't it make more sense when using timers to rather use the sinon stubs? (eg.
sinon.useFakeTimers()
)Rest looks fine.
That way you can step through and se the clocks to whichever times you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought about that as well. Decided for
await delay(9)
(which is somewhat random tbh) because using fake timers introduces potential errors & bugs by manipulating the global timing functions.Have no real opinion on this, will adapt to whatever you and @ngotchac prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not going to grumble, just think that we have a bit more control with actually moving the timer ahead. Well, I've had some success with it.
https://github.com/ethcore/parity/blob/7cdfaf1a439a5287b55b4195b29878193f0d7049/js/src/3rdparty/shapeshift/shapeshift.spec.js#L173
Either way, what we have works.
(Only error, as with any stubbing, is not restoring - beforeEach/afterEach to the rescue)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to use sinon sandboxes (they are really great) but they don't have
reset
, onlyrestore
. That's why I chose functions to create the mocks.