This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Returning default account as coinbase + allow altering sender in signer #4323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coinbase will now return first account for particular dapp (so you can either use
web3.eth.accounts[0]
orweb3.eth.coinbase
) to get default account.We agreed with @jacogr that the UI will always set default account as first on the list (either using
parity_setDappsAddresses(dapp, [accounts])
orparity_setNewDappsWhitelist([accounts])
)Additionally signer RPC now allows to override transaction sender. PR allowing to omit
from
inTransactionRequest
will follow.Related: #3797