OPENEUROPA-1837: Replace CAS references with EU Login. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upchuk
requested changes
May 6, 2019
There was a problem hiding this comment.
@imanoleguskiza What you did looks good. But let's go a bit further and replace "CAS" instances with "EU Login". See screenshot:
|
My bad, I just followed the items in the ticket and failed to double check other instances. |
imanoleguskiza
force-pushed
the
OPENEUROPA-1837
branch
from
f7bbe78
to
bbd8e30
Compare
upchuk
requested changes
May 6, 2019
oe_authentication.module
Outdated
| function oe_authentication_form_bulk_add_cas_users_alter(&$form, &$form_state, $form_id) { | ||
|
|
||
| if (isset($form['intro']['#markup'])) { | ||
| $form['intro']['#markup'] = t("Use this form to pre-register one or more users, allowing them to log in using EU Login."); |
src/Routing/RouteSubscriber.php
Outdated
| @@ -47,6 +47,14 @@ protected function alterRoutes(RouteCollection $collection): void { | |||
| '_controller' => '\Drupal\oe_authentication\Controller\ProxyCallbackController::callback', | |||
| ]); | |||
| } | |||
|
|
|||
| // Replace default cas login route with eulogin one. | |||
| $route = $collection->get('cas.login'); | |||
There was a problem hiding this comment.
Let's check if these routes exist before changing them.
upchuk
approved these changes
May 6, 2019
sergepavle
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-1837
Description
Replace CAS references with EU Login.
Change log
Commands