Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OEL-1425: Change image arrays to ImageValueObject in patterns. #229

Merged
merged 1 commit into from
Apr 11, 2022
Merged

OEL-1425: Change image arrays to ImageValueObject in patterns. #229

merged 1 commit into from
Apr 11, 2022

Conversation

escuriola
Copy link
Contributor

drishu
drishu approved these changes Apr 10, 2022
View reviewed changes
Copy link
Contributor

@drishu drishu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already approve, up to you and @brummbar , we could also do banner, it is used in whitelabel paragraphs and the preprocess already instantiates an ImageValueObject

@brummbar
Copy link
Contributor

We are using it in banner paragraph but wrong, as we only use the src at the end. So it's not needed.

@brummbar brummbar merged commit c275f30 into 1.x Apr 11, 2022
@brummbar brummbar deleted the OEL-1425 branch April 11, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drishu drishu drishu approved these changes

@brummbar brummbar brummbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@escuriola @brummbar @drishu