-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OEL-1418: Remove obsolete paragraphs requirements from oe_bootstrap_theme #243
Conversation
…lder version section.
* openeuropa/oe_paragraphs | ||
|
||
Be sure to require the component if you need any of them. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should mention that you need to upgrade to alpha8 first if you had something older than that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has sense? I'm reading the upgrade to 1.0.0-beta2 section, and the requirements to to the previous version is inherent...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point is you will need a separate deployment.
Although, maybe this is only relevant once we fully remove the oe_bootstrap_theme_paragraphs module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drishu thoughts? ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the upgrade path from < alpha8.
There are problems, but they are fully covered by the comment that you already added here.
We will need to add another line later if/when we actually remove oe_bootstrap_theme_paragraphs.
So ok for now :)
README.md
Outdated
@@ -189,6 +189,17 @@ We use [SemVer](http://semver.org/) for versioning. For the available versions, | |||
|
|||
## Upgrade from older versions | |||
|
|||
### Upgrade to 1.0.0-beta2 | |||
|
|||
The following paragraphs required components have been removed from [OpenEuropa Bootstrap base theme](https://github.com/openeuropa/oe_bootstrap_theme) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is a "paragraphs required component"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the list below is about composer packages, we should say that:
The following paragraphs required components have been removed from [OpenEuropa Bootstrap base theme](https://github.com/openeuropa/oe_bootstrap_theme) | |
Dependencies to the following packages have been removed in composer.json: |
just a proposal, feel free to improve
Jira issue(s):
https://citnet.tech.ec.europa.eu/CITnet/jira/browse/OEL-1418