Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEL-1418: Remove obsolete paragraphs requirements from oe_bootstrap_theme #243

Merged
merged 5 commits into from
Jun 3, 2022

Conversation

escuriola
Copy link
Contributor

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
drishu
drishu previously approved these changes May 30, 2022
* openeuropa/oe_paragraphs

Be sure to require the component if you need any of them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should mention that you need to upgrade to alpha8 first if you had something older than that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has sense? I'm reading the upgrade to 1.0.0-beta2 section, and the requirements to to the previous version is inherent...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point is you will need a separate deployment.
Although, maybe this is only relevant once we fully remove the oe_bootstrap_theme_paragraphs module.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drishu thoughts? ^

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the upgrade path from < alpha8.
There are problems, but they are fully covered by the comment that you already added here.
We will need to add another line later if/when we actually remove oe_bootstrap_theme_paragraphs.
So ok for now :)

README.md Outdated
@@ -189,6 +189,17 @@ We use [SemVer](http://semver.org/) for versioning. For the available versions,

## Upgrade from older versions

### Upgrade to 1.0.0-beta2

The following paragraphs required components have been removed from [OpenEuropa Bootstrap base theme](https://github.com/openeuropa/oe_bootstrap_theme)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a "paragraphs required component"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the list below is about composer packages, we should say that:

Suggested change
The following paragraphs required components have been removed from [OpenEuropa Bootstrap base theme](https://github.com/openeuropa/oe_bootstrap_theme)
Dependencies to the following packages have been removed in composer.json:

just a proposal, feel free to improve

@escuriola escuriola merged commit c24bb13 into 1.x Jun 3, 2022
@escuriola escuriola deleted the OEL-1418 branch June 3, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants