OEL-461: Additional class for toggling button visibility. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drishu
requested changes
Sep 15, 2021
| @@ -16,7 +20,7 @@ | |||
| 'extra_classes_close': extra_classes_close, | |||
| } %} | |||
| {% if with_trigger %} | |||
| <button class="btn btn-primary" type="button" data-bs-toggle="offcanvas" data-bs-target="#{{ offcanvas_id }}" aria-controls="{{ offcanvas_id }}"> | |||
| <button class="btn btn-primary d-lg-none" type="button" data-bs-toggle="offcanvas" data-bs-target="#{{ offcanvas_id }}" aria-controls="{{ offcanvas_id }}"> | |||
| Toggle offcanvas | |||
There was a problem hiding this comment.
Change the pattern, add a field for the button label, default to "Toggle offcanvas"
| @@ -5,7 +5,11 @@ | |||
| */ | |||
| #} | |||
| {% include '@oe-bcl/bcl-offcanvas/offcanvas.html.twig' with { | |||
| 'title': title, | |||
| 'title': { | |||
There was a problem hiding this comment.
this revert, move the extra stuff to templates/overrides/search/block--facets-form.html.twig in whitelabel
drishu
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is tied to https://citnet.tech.ec.europa.eu/CITnet/jira/browse/OEL-461
The missing class on the toggle button makes it disappear when in desktop mode and visible when in mobile.