Front 2490: Table pattern #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxfire
force-pushed
the
FRONT-2490
branch
2 times, most recently
from
20568b0
to
285f385
Compare
abel-santos-corral
previously approved these changes
Sep 27, 2021
escuriola
suggested changes
Sep 28, 2021
| {% set rows_items = rows_items|merge([{'cells': row_content}]) %} | ||
| {% endfor %} | ||
| {{ pattern('table', { | ||
| caption: caption, |
There was a problem hiding this comment.
Missing table_responsive:
Suggested change
| caption: caption, | |
| caption: caption, | |
| table_responsive: responsive ? true... |
There was a problem hiding this comment.
As we checked it's already in place.
| caption: caption, | ||
| rows: rows_items, | ||
| table_head: table_head, | ||
| }) }} |
There was a problem hiding this comment.
Details (summary and description) also missing inside caption.
There was a problem hiding this comment.
Checking with "seven" theme, seems to be a collapsible field. The summary is the link and the description the content.
There was a problem hiding this comment.
Added in the view template.
| </table> | ||
| </div> | ||
| {{ pattern('table', { | ||
| caption: caption, |
There was a problem hiding this comment.
Suggested change
| caption: caption, | |
| caption: caption, | |
| table_responsive: true, |
There was a problem hiding this comment.
same as before, it's already in place.
Maxfire
force-pushed
the
FRONT-2490
branch
2 times, most recently
from
791ae10
to
36604c9
Compare
drishu
approved these changes
Oct 1, 2021
escuriola
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue(s):