D8AGE-291: The translate actions. #309
Conversation
This was actually the problem with the The drone issues have also been fixed, probably an update to phpcs as it started complaining about trailing commas in multiline function definitions. This has also been fixed. Now the drone fails in the composer install, I'll try to trigger it again later. |
modules/oe_translation_cdt/tests/src/Kernel/TranslationRequestUpdaterTest.php
Show resolved
Hide resolved
modules/oe_translation_cdt/tests/src/FunctionalJavascript/TranslationProviderTest.php
Outdated
Show resolved
Hide resolved
| @@ -221,4 +304,24 @@ protected function assertLogMessagesTable(array $logs): void { | |||
| $this->assertEquals($logs, $actual); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I am missing the cases where a language is cancelled. From the top of my head:
- One request with two languages: an accepted language and a cancelled language -> request finished
- One request with one language: cancelled language -> request finished.
There was a problem hiding this comment.
Done, I've also added a function that creates a new translation request. I'll move it to a trait when we have more functional tests.
| foreach ($all_statuses as $status => $label) { | ||
| $operations[$status] = [ | ||
| 'title' => sprintf('Update status to %s (mock)', $label), | ||
| 'url' => Url::fromRoute('oe_translation_cdt_mock.request_status', [ |
There was a problem hiding this comment.
Not sure why but when using the "In progress" update option, there is no information logged in the request. Afaik we do not have an ongoing status for our requests but we should still log the update in the request logs. Same thing happens for the job updates
There was a problem hiding this comment.
We've got only these states of request in the CDT:
- COMP - The request has been completed and delivered.
- INPR - The request is in progress or request for quotation approved.
- CANC - The request has been cancelled
- PEND - The request quotation is ready to be approved by the client (Requests for Quotation only).
- UNDE - The request quotation is under quotation.
So I have no way to distinguish "requested" from "in progress".
The log is only written when there is an actual change. When you start the translation, it is already in INPR state.
| /** | ||
| * Implements hook_ENTITY_TYPE_presave(). | ||
| */ | ||
| function oe_translation_cdt_oe_translation_request_presave(TranslationRequestCdtInterface $request) { |
There was a problem hiding this comment.
If both the cdt and poetry module are enabled, this will fail because poetry will save entities with a different interface. The paramer type should be TranslationRequestInterface and then we check whether it implements the cdt interface
| @@ -140,49 +140,132 @@ public function testCdtSingleTranslationFlow(): void { | |||
| $translator->setProviderConfiguration($configuration); | |||
| $translator->save(); | |||
|
|
|||
| $node = $this->createBasicTestNode('oe_demo_translatable_page', "The translation's page"); | |||
There was a problem hiding this comment.
I've just moved it to the separate function, but the diff looks weird here...
D8AGE-341: Create dashboard for CDT translations.
D8AGE-291
Description
This PR adds actions to the translate page. Thanks to it, you can work with translations and accept them.