Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: use Makefile to run shell scripts #97

Closed
itscaro opened this issue Sep 14, 2017 · 3 comments
Closed

Proposal: use Makefile to run shell scripts #97

itscaro opened this issue Sep 14, 2017 · 3 comments
Labels

Comments

@itscaro
Copy link
Contributor

itscaro commented Sep 14, 2017

Use Makefile instead of shell scripts

Expected Behaviour

Tasks are organized in makefiles folder along with the main Makefile at root.
Current scripts will call the corresponding makefile rule in order to maintain backward compatibility.

build.sh calls make build
build_redist.sh calls make build_redist
test/version.sh calls make test_version
deploy_samples calls make deploy_samples

make test runs go test in docker image to test against a specific version of Go

@rgee0
Copy link
Contributor

rgee0 commented Sep 14, 2017

Derek add label: proposal

@ghost ghost added the proposal label Sep 14, 2017
@alexellis
Copy link
Member

Will come back to this.

@alexellis alexellis added revisit and removed proposal labels Oct 3, 2017
@alexellis
Copy link
Member

We have a Makefile now. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants