Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging parameters for oidc-plugin #1205

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

welteki
Copy link
Member

@welteki welteki commented Apr 23, 2024

Description

Support configuration parameters for structured logging for the oidc-plugin in the OpenFaaS Helm chart.

Parameter Description Default
oidcAuthPlugin.logs.debug Log debug messages false
oidcAuthPlugin.logs.format Set the log format, supports console or json console

Why is this needed?

  • I have raised an issue to propose this change (required)

Support structured logging for the oidc-plugin.

Who is this for?

What company is this for? Are you listed in the ADOPTERS.md file?

How Has This Been Tested?

Verified the log level end log encoding can be configured correctly through the Helm chart.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

The parameter oidcAuthPlugin.verbose was removed and is replaces by oidcAuthPlugin.logs.debug.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit bd99515 into openfaas:master Apr 23, 2024
3 checks passed
@welteki welteki deleted the oidc-plugin-logging branch April 23, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants