Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for feedback/ideas for FaaS Metric Collection with Prometheus #1653

Closed
bwplotka opened this issue Jun 19, 2021 · 7 comments
Closed

Call for feedback/ideas for FaaS Metric Collection with Prometheus #1653

bwplotka opened this issue Jun 19, 2021 · 7 comments

Comments

@bwplotka
Copy link

Hi!

Sorry if creating an issue for this is not the right way, but I can see OpenFaas is recommending Prometheus for metric collection: https://docs.openfaas.com/architecture/metrics/

As the Prometheus community, we are looking for feedback/ideas on how to improve monitoring of the world of Serverless/FaaS. In this thread, I am specifically looking for:

  • Existing best practices for using Prometheus for gathering metrics from Serverless/FaaS platforms and functions
  • Specific gaps and limitation users might have in these scenarios
  • Existing success stories?
  • Ideas for improvements.

If you want to help please feel free to respond on prometheus-dev mailing list: https://groups.google.com/g/prometheus-developers/c/FPe0LsTfo2E 🤗

@kevin-lindsay-1
Copy link

I can try to give any feedback you'd like, but this seems like it would be better suited for the OpenFaaS Slack than as a GitHub issue. As you can see, probably nobody even looked at this, whereas the Slack group is probably going to get you more visibility.

@adaliszk
Copy link

In the recent tag (0.21.3), it seems that there was a change to limit the Prometheus check for the function namespace when getting the list of functions. That is all fine, however, it seems that the gateway_function_invocation_total's function_name no longer has the namespace in its name. This causes the listing call to always return an empty list.

@alexellis
Copy link
Member

alexellis commented Feb 24, 2022

@adaliszk I don't believe we've met, can you give yourself an introduction please?

In the recent tag (0.21.3), it seems that there was a change to limit the Prometheus check for the function namespace when getting the list of functions. That is all fine, however, it seems that the gateway_function_invocation_total's function_name no longer has the namespace in its name. This causes the listing call to always return an empty list.

Please raise your own issue with a full repro. This is not my understanding, I use this feature regularly and see the steps you're running.

@alexellis
Copy link
Member

alexellis commented Feb 24, 2022

gateway             1/1     1            1           5h    gateway,faas-netes   ghcr.io/openfaas/gateway:0.21.3,ghcr.io/openfaasltd/faas-netes:0.1.2   app=gateway

Screenshot from 2022-02-24 16-28-29

@alexellis
Copy link
Member

I confirmed with @kevin-lindsay-1 that he is also seeing metrics as expected.

@alexellis
Copy link
Member

Hi @bwplotka - please feel free to reach out to me directly via email alex / openfaas / com

Happy to schedule some time to speak to you about this.

Alex

@alexellis
Copy link
Member

/lock: resolved

@derek derek bot locked and limited conversation to collaborators Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants