Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use of template to Install command #3

Merged
merged 1 commit into from
Dec 29, 2019

Conversation

Waterdrips
Copy link
Contributor

The tamplate name wasnt used, so
the command gave an error saying that
no template was used.

Signed-off-by: Alistair Hey alistair@heyal.co.uk

Tested:
BEFORE:

root@raspberrypi:~/go/src/github.com/alexellis/faasd# sudo faasd install
Error: error loading template ./hack/faas-containerd.service, error template: no files named in call to ParseFiles

AFTER:

root@raspberrypi:~/go/src/github.com/alexellis/faasd# sudo ./faasd install
root@raspberrypi:~/go/src/github.com/alexellis/faasd# 

@alexellis
Copy link
Member

Thanks for this PR 👍

The tamplate name wasnt used, so
the command gave an error saying that
no template was used.

Could you fix the typo and wrap to 80 chars for the error messages? I use the text under the commit message as a guide on length.

i.e.

# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.

The template name wasnt used, so the command gave an error saying
that no template was used.

Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
@alexellis alexellis merged commit f76432f into openfaas:master Dec 29, 2019
@alexellis
Copy link
Member

Thanks for reformatting the commit message again, it is 72 chars not 80 (I was wrong)

@Waterdrips Waterdrips deleted the fix-install branch December 29, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants