Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable containerd on reboot #49

Merged
merged 1 commit into from Feb 23, 2020
Merged

Enable containerd on reboot #49

merged 1 commit into from Feb 23, 2020

Conversation

gabeduke
Copy link
Contributor

@gabeduke gabeduke commented Feb 23, 2020

Fixes #48

Description

Motivation and Context

  • I have raised an issue to propose this change this is required

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Commits:

  • I've read the CONTRIBUTION guide
  • My commit message has a body and describe how this was tested and why it is required.
  • I have signed-off my commits with git commit -s for the Developer Certificate of Origin (DCO)

Code:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.

Docs:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@derek
Copy link

derek bot commented Feb 23, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot added the no-dco label Feb 23, 2020
Fixes openfaas#48

Signed-off-by: Gabriel Duke <gabeduke@gmail.com>
@gabeduke
Copy link
Contributor Author

gabeduke commented Feb 23, 2020

I don't know why the tests are failing there was no functional changes to the codebase.

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM surprised this wasn't the default

@alexellis alexellis merged commit 93325b7 into openfaas:master Feb 23, 2020
@alexellis
Copy link
Member

Much appreciated, thank you for helping us improve faasd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Containerd service not enabled in user-data
2 participants