Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instructions for bootstrapping faasd on digitalocean #70

Merged
merged 3 commits into from
May 27, 2020
Merged

Add instructions for bootstrapping faasd on digitalocean #70

merged 3 commits into from
May 27, 2020

Conversation

mehyedes
Copy link
Contributor

@mehyedes mehyedes commented Apr 18, 2020 •
edited

Signed-off-by: Mehdi Yedes mehdi.yedes@gmail.com

Added instructions for provisioning a faasd instance on Digitalocean with or without TLS.

Description

This PR integrates the following gists:

into the faasd repository.
I have also updated the README.md file to include the guides.

Motivation and Context

How Has This Been Tested?

Tested the provisioning with terraform on Digitalocean.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Commits:

  • I've read the CONTRIBUTION guide
  • My commit message has a body and describe how this was tested and why it is required.
  • I have signed-off my commits with git commit -s for the Developer Certificate of Origin (DCO)

Code:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.

Docs:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mehyedes
Include instructions for bootstrapping faasd on digitalocean
aec38a3 
Signed-off-by: Mehdi Yedes <mehdi.yedes@gmail.com>
@mehyedes
Update README.md
2559a90 
Signed-off-by: Mehdi Yedes <mehdi.yedes@gmail.com>
@mehyedes mehyedes mentioned this pull request Apr 18, 2020
Closed
alexellis
alexellis reviewed Apr 29, 2020
View reviewed changes
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're OK with it, can we retain my gist as the non-TLS example, and add your example underneath?

could the folder dgitalocean-tls be renamed to digitalocean-terraform?

@mehyedes
Reorganise docs/ folder
f1121f2 
Signed-off-by: Mehdi Yedes <mehdi.yedes@gmail.com>
@mehyedes
Copy link
Contributor Author

mehyedes commented May 3, 2020

If you're OK with it, can we retain my gist as the non-TLS example, and add your example underneath?

could the folder dgitalocean-tls be renamed to digitalocean-terraform?

Done
Is this what you meant?

docs/
├── bootstrap/
│   ├── digitalocean-terraform/
│   │   ├── cloud-config.tpl
│   │   ├── main.tf
│   │   ├── main.tfvars
│   │   └── README.md
│   ├── cloud-config.tpl
│   ├── main.tf
│   └── README.md
└── DEV.md

@mehyedes mehyedes requested a review from alexellis May 3, 2020 11:15
alexellis
alexellis reviewed May 11, 2020
View reviewed changes
README.md
@@ -56,7 +56,9 @@ You can run this tutorial on your Raspberry Pi, or adapt the steps for a regular

Automate everything within < 60 seconds and get a public URL and IP address back. Customise as required, or adapt to your preferred cloud such as AWS EC2.

* [Provision faasd 0.7.5 on DigitalOcean with Terraform 0.12.0](https://gist.github.com/alexellis/fd618bd2f957eb08c44d086ef2fc3906)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant not to delete this? Or did you just copy my gist into docs/bootstrap/README.md?

Copy link
Contributor Author

@mehyedes mehyedes May 11, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, I have only updated the faasd version to 0.8.1 and copied it to docs/bootstrap/README.md.
Is that ok, or would you prefer to keep it as a gist?
I thought we'd keep both options: TLS and non-TLS at the same place

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK thanks for explaining

mehyedes
mehyedes commented May 11, 2020
View reviewed changes
docs/bootstrap/digitalocean-terraform/README.md

1) [Sign up to DigitalOcean](https://www.digitalocean.com/?refcode=2962aa9e56a1&utm_campaign=Referral_Invite&utm_medium=Referral_Program&utm_source=CopyPaste)
2) [Download Terraform](https://www.terraform.io)
3) Clone this gist using the URL from the address bar
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed I am still referring to the gist here. Should be changed to refer to the faasd repo instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please

@alexellis
Copy link
Member

Has anyone run through this to test for you? I think @utsavanand2 and then @Waterdrips both committed to doing that, but I haven't seen anything on the PR yet.

@alexellis alexellis merged commit 25c553a into openfaas:master May 27, 2020
@alexellis
Copy link
Member

Let's merge this, then it's easier for others to test. Could you also refer to the repo instead of the gist as per your comment above @mehyedes ? If you have other suggestions for changes please feel free to propose them too.

@mehyedes mehyedes mentioned this pull request Jun 1, 2020
Closed
4 tasks
@mehyedes
Copy link
Contributor Author

mehyedes commented Jun 1, 2020

Has anyone run through this to test for you? I think @utsavanand2 and then @Waterdrips both committed to doing that, but I haven't seen anything on the PR yet.

Not yet unfortunately.
But I have created a new PR to update the instructions.

@mrsimonemms mrsimonemms mentioned this pull request Sep 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexellis alexellis alexellis left review comments

Assignees
No one assigned
Labels
new-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mehyedes @alexellis