Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap readme #77

Closed
wants to merge 1 commit into from

Conversation

mehyedes
Copy link
Contributor

@mehyedes mehyedes commented Jun 1, 2020

This PR completes #70

Description

Updated the instructions to reflect the move from gist to the faasd github repo.

Motivation and Context

Related to #70
which solves #67

  • I have raised an issue to propose this change this is required

Checklist:

Commits:

  • I've read the CONTRIBUTION guide
  • My commit message has a body and describe how this was tested and why it is required.
  • I have signed-off my commits with git commit -s for the Developer Certificate of Origin (DCO)

@alexellis
Copy link
Member

Sorry @mehyedes could you rebase? If not, please feel free to close and log an issue if this is still needed.

@mehyedes
Copy link
Contributor Author

Hey @alexellis
I would say this is still needed as the README files still mention the gists. I'll rebase it.

@mehyedes
Copy link
Contributor Author

Hey @alexellis
I have rebased and squashed my commits. Please have a quick look again and merge if everything is fine.

docs/bootstrap/README.md Outdated Show resolved Hide resolved
@@ -2,7 +2,12 @@

1) [Sign up to DigitalOcean](https://www.digitalocean.com/?refcode=2962aa9e56a1&utm_campaign=Referral_Invite&utm_medium=Referral_Program&utm_source=CopyPaste)
2) [Download Terraform](https://www.terraform.io)
3) Clone this gist using the URL from the address bar
3) Download the [cloud-config.tpl](cloud-config.tpl) and [main.tf](main.tf) files.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have to do that when following the main blog post? https://www.openfaas.com/blog/faasd-tls-terraform/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, because there is an instruction to clone the faasd repo earlier in the blog post, but not here. Should we also add that instruction here as well?
I just thought it would make more sense if one only has to download the needed files cloud-config.tpl and main.tf here instead of cloning the whole faasd repo.
What would be better in your opinion?

@Lewiscowles1986 Lewiscowles1986 mentioned this pull request Dec 20, 2020
10 tasks
@mehyedes mehyedes force-pushed the update-bootstrap-readme branch 2 times, most recently from 228e147 to 55938aa Compare December 26, 2020 15:11
Signed-off-by: Mehdi Yedes <mehdi.yedes@gmail.com>
@alexellis
Copy link
Member

Things have changed since last December, so I wasn't sure if we needed this any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants