-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bootstrap readme #77
Conversation
Sorry @mehyedes could you rebase? If not, please feel free to close and log an issue if this is still needed. |
Hey @alexellis |
89b314c
to
a234467
Compare
Hey @alexellis |
@@ -2,7 +2,12 @@ | |||
|
|||
1) [Sign up to DigitalOcean](https://www.digitalocean.com/?refcode=2962aa9e56a1&utm_campaign=Referral_Invite&utm_medium=Referral_Program&utm_source=CopyPaste) | |||
2) [Download Terraform](https://www.terraform.io) | |||
3) Clone this gist using the URL from the address bar | |||
3) Download the [cloud-config.tpl](cloud-config.tpl) and [main.tf](main.tf) files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have to do that when following the main blog post? https://www.openfaas.com/blog/faasd-tls-terraform/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, because there is an instruction to clone the faasd repo earlier in the blog post, but not here. Should we also add that instruction here as well?
I just thought it would make more sense if one only has to download the needed files cloud-config.tpl
and main.tf
here instead of cloning the whole faasd repo.
What would be better in your opinion?
228e147
to
55938aa
Compare
Signed-off-by: Mehdi Yedes <mehdi.yedes@gmail.com>
55938aa
to
af73f32
Compare
Things have changed since last December, so I wasn't sure if we needed this any more. |
This PR completes #70
Description
Updated the instructions to reflect the move from gist to the faasd github repo.
Motivation and Context
Related to #70
which solves #67
Checklist:
Commits:
git commit -s
for the Developer Certificate of Origin (DCO)