Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission Request, pwgen #31

Open
playgali opened this issue Apr 20, 2018 · 9 comments
Open

Submission Request, pwgen #31

playgali opened this issue Apr 20, 2018 · 9 comments

Comments

@playgali
Copy link

playgali commented Apr 20, 2018

Hello Guys, home I'm doing this right, I submit for your review the following "Function" to be added to the store both armhf and x86_64

{
  "title": "Password Generator",
  "description": "Basic implementation of the known linux 'pwgen' command, for OpenFaas, armhf",
  "image": "playgali/faas_pwgen:latest-armhf",
  "name": "pwgen",
  "fprocess": "xargs pwgen -s",
  "network": "func_functions",
  "repo_url": "https://github.com/playgali/faas_pwgen",
  "labels": {
    "com.openfaas.ui.ext": "txt"
  },
  "environment": {
    "write_timeout": "10"
  }
}

and the other one

{
  "title": "Password Generator",
  "description": "Basic implementation of the known linux 'pwgen' command, for OpenFaas",
  "image": "playgali/faas_pwgen:latest",
  "name": "pwgen",
  "fprocess": "xargs pwgen -s",
  "network": "func_functions",
  "repo_url": "https://github.com/playgali/faas_pwgen",
  "labels": {
    "com.openfaas.ui.ext": "txt"
  },
  "environment": {
    "write_timeout": "10"
  }
}

Thank you for your time

@ivanayov
Copy link
Contributor

@alexellis I tested the function. WDYT? It's good to have.

@alexellis
Copy link
Member

Looks fine to me, but can I ask that you re-create the GitHub repo on GitHub and then transfer it to the faas-and-furious repo? We're trying to maintain all the store images in one place so we can move them over to our own CI in time.

@playgali
Copy link
Author

Should I create the repo on github? or was that message for @iyovcheva ?

@ivanayov
Copy link
Contributor

@playgali I think it was to you if you're fine with migrating your code to GitHub

@playgali
Copy link
Author

It is done friends!!, The repos are now on GitHub

@alexellis
Copy link
Member

Great.. can you transfer ownership of the repo to me? alexellis. I'll then move it to faas-and-furious

@playgali
Copy link
Author

its done, you probably have a better base image for all functions, so you might have to edit it a little bit

@alexellis
Copy link
Member

Base image is probably not needed.. it looked like we just needed the watchdog and a single package from apk?

@playgali
Copy link
Author

thats right, its just a basic example I used for a presentation back in April

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants