Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/bump RI packages #77

Merged
merged 5 commits into from
Apr 11, 2023
Merged

Feat/bump RI packages #77

merged 5 commits into from
Apr 11, 2023

Conversation

cwang
Copy link
Contributor

@cwang cwang commented Apr 11, 2023

Description

Please include a summary of the change, e.g. what the new feature # is and/or what bug # it fixes. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes/Implements #(issue/feature)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor and code improvement (non-breaking change which improves code quality and/or performance)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation
  • Tests
  • Other chores such as maintenance

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration by modifying the list below.

  • Test A
  • Test B
  • Test C

Test Configuration:

Please describe the test setup. List them below as bullet points.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • The commit message follows the convention of this project

@cwang cwang requested a review from a team as a code owner April 11, 2023 07:34
@cwang
Copy link
Contributor Author

cwang commented Apr 11, 2023

@janaka for cdktf-typescript sample package, it's missing a few metadata files such as cdf.metadata.json - would you mind adding them retrospectively pls? See what's in awscdk-typesript sample package for examples.

Either push directly in this PR or create a branch PR

@cwang cwang merged commit a6bf097 into main Apr 11, 2023
@cwang cwang deleted the feat/bump-ri-packages branch April 11, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant