Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for modular models metadata #141

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

ewanharris
Copy link
Member

@ewanharris ewanharris commented Mar 8, 2024

Description

This PR introduces the metadata required for modular models. Namely, the file and module fields on TypeDefintions, Relations, and Conditions.

I'm very much a protobuf noob so please call out any extra additions that are needed, I tried to keep the validation aligned with what exists currently.

References

Closes #137

See the updated RFC PR for an example of these additions openfga/rfcs#18

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested review from a team as code owners March 8, 2024 11:20
@ewanharris ewanharris linked an issue Mar 8, 2024 that may be closed by this pull request
@ewanharris ewanharris force-pushed the feat/137-modular-models-additions branch 3 times, most recently from 6886b39 to 2f8febe Compare March 11, 2024 13:49
rhamzeh
rhamzeh previously approved these changes Mar 11, 2024
@jon-whit
Copy link
Contributor

@ewanharris would you please, for the record, include some examples of these protobufs for some file and module structures? That will make future me understand the field structure of these changes better (when I reflect back on this), and it will make it easier to review at the current time as well.

rhamzeh
rhamzeh previously approved these changes Mar 12, 2024
jon-whit
jon-whit previously approved these changes Mar 12, 2024
@ewanharris ewanharris dismissed stale reviews from jon-whit and rhamzeh via 0c60990 March 12, 2024 18:00
@ewanharris ewanharris merged commit 66b9e5c into main Mar 18, 2024
7 checks passed
@ewanharris ewanharris deleted the feat/137-modular-models-additions branch March 18, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Modular Models
4 participants