-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for modular models metadata #141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ewanharris
force-pushed
the
feat/137-modular-models-additions
branch
3 times, most recently
from
March 11, 2024 13:49
6886b39
to
2f8febe
Compare
rhamzeh
previously approved these changes
Mar 11, 2024
ewanharris
force-pushed
the
feat/137-modular-models-additions
branch
from
March 11, 2024 18:41
2f8febe
to
c192c17
Compare
@ewanharris would you please, for the record, include some examples of these protobufs for some file and module structures? That will make future me understand the field structure of these changes better (when I reflect back on this), and it will make it easier to review at the current time as well. |
jon-whit
reviewed
Mar 11, 2024
jon-whit
reviewed
Mar 11, 2024
jon-whit
reviewed
Mar 11, 2024
ewanharris
force-pushed
the
feat/137-modular-models-additions
branch
from
March 12, 2024 11:47
3c2a858
to
13fe360
Compare
4 tasks
rhamzeh
previously approved these changes
Mar 12, 2024
jon-whit
previously approved these changes
Mar 12, 2024
miparnisari
reviewed
Mar 12, 2024
miparnisari
approved these changes
Mar 12, 2024
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the metadata required for modular models. Namely, the
file
andmodule
fields on TypeDefintions, Relations, and Conditions.I'm very much a protobuf noob so please call out any extra additions that are needed, I tried to keep the validation aligned with what exists currently.
References
Closes #137
See the updated RFC PR for an example of these additions openfga/rfcs#18
Review Checklist
main