feat: add query consistency params #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyjames
commented
Jun 6, 2024
rhamzeh
reviewed
Jun 6, 2024
rhamzeh
reviewed
Jun 6, 2024
rhamzeh
approved these changes
Jun 6, 2024
jimmyjames
added a commit
that referenced
this pull request
Jun 21, 2024
* feat: add consistency enum parameter for query APIs * fix CI workflow branch name * ignore enum suffix lint rule * ignore enum val prefix lint warning * fix up generated files * docs formatting fix * review feedback: update enum vals for future additions, update docs * fix up docs clarification for all endpoints
4 tasks
ewanharris
added a commit
that referenced
this pull request
Jul 23, 2024
* setup feat/stronger-consistency branch * feat: add query consistency params (#170) * feat: add consistency enum parameter for query APIs * fix CI workflow branch name * ignore enum suffix lint rule * ignore enum val prefix lint warning * fix up generated files * docs formatting fix * review feedback: update enum vals for future additions, update docs * fix up docs clarification for all endpoints * feat: add consistency options to StreamedListObjects * doc: correct consistency reference in doc string (#182) * doc: correct consistency reference in doc string * chore: remove dx from codeowners as we're moving off feature branch * Merge main int feat/stronger-consistency-options (#184) ci: don't pin version of buf (#181) * ci: don't pin version of buf Instead we will use the version that correlates to the action version * chore(deps): update buf-setup-action version * style: run buf format to make formatting changes --------- Co-authored-by: Jim Anderson <jim.anderson@okta.com> Co-authored-by: Raghd Hamzeh <raghd.hamzeh@auth0.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
consistencyparameter to the following endpoints:The parameter is an enum with two values:
MINIMIZE_LATENCY- default, behavior is as-is todayHIGHER_CONSISTENCY- used to signal to the API to prefer higher consistency at the expense of potentially reduced performanceReferences
Review Checklist
main