Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support list users #80

Merged
merged 2 commits into from
May 2, 2024
Merged

feat: support list users #80

merged 2 commits into from
May 2, 2024

Conversation

ewanharris
Copy link
Member

Description

Adds support for the list users API.

I've not introduced to the example project because that needs a docker container to be published with the API because it's ran as part of the integration tests.

References

Generated from openfga/sdk-generator#355

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested review from a team as code owners May 1, 2024 14:43
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 19.46309% with 480 lines in your changes are missing coverage. Please review.

Project coverage is 27.72%. Comparing base (9b94a4d) to head (6b38a68).

Files Patch % Lines
...va/dev/openfga/sdk/api/model/ListUsersRequest.java 14.91% 97 Missing ⚠️
...a/dev/openfga/sdk/api/model/ListUsersResponse.java 13.23% 59 Missing ⚠️
...api/model/UnprocessableContentMessageResponse.java 0.00% 49 Missing ⚠️
...in/java/dev/openfga/sdk/api/model/UsersetUser.java 23.72% 40 Missing and 5 partials ⚠️
...ava/dev/openfga/sdk/api/model/ObjectOrUserset.java 0.00% 44 Missing ⚠️
...java/dev/openfga/sdk/api/model/UserTypeFilter.java 14.89% 40 Missing ⚠️
src/main/java/dev/openfga/sdk/api/model/User.java 26.41% 34 Missing and 5 partials ⚠️
...main/java/dev/openfga/sdk/api/model/FgaObject.java 25.53% 32 Missing and 3 partials ⚠️
.../java/dev/openfga/sdk/api/model/TypedWildcard.java 18.91% 28 Missing and 2 partials ⚠️
...a/sdk/api/model/UnprocessableContentErrorCode.java 0.00% 16 Missing ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #80      +/-   ##
============================================
- Coverage     28.65%   27.72%   -0.94%     
- Complexity      723      787      +64     
============================================
  Files           145      158      +13     
  Lines          5283     5879     +596     
  Branches        567      645      +78     
============================================
+ Hits           1514     1630     +116     
- Misses         3712     4173     +461     
- Partials         57       76      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @ewanharris!

Was talking to @rhamzeh today, we'll need to add the storeId to the various request options to as we do for the authorizationModelId to support per-request store-specific requests, but that will be a larger refactor outside the scope of this PR. This looks good 👍

@ewanharris ewanharris added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit c6f9926 May 2, 2024
19 checks passed
@ewanharris ewanharris deleted the feat/list-users branch May 2, 2024 11:09
@ewanharris ewanharris mentioned this pull request May 2, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants