Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix and Improve readability #164

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Conversation

tmsagarofficial
Copy link
Contributor

Description

Typo fix and Improve readability

References

This is for the openfga/sdk-generator#425

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • [NA] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • [NA] I have added tests to validate that the change in functionality is working as expected

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.94%. Comparing base (10534cc) to head (1103aed).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   87.94%   87.94%           
=======================================
  Files          23       23           
  Lines        1120     1120           
  Branches      171      171           
=======================================
  Hits          985      985           
  Misses         83       83           
  Partials       52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments about the changes here

README.md Outdated Show resolved Hide resolved
example/README.md Outdated Show resolved Hide resolved
docs/opentelemetry.md Show resolved Hide resolved
docs/opentelemetry.md Outdated Show resolved Hide resolved
tmsagarofficial and others added 3 commits October 7, 2024 21:28
Co-authored-by: Ewan Harris <ewanharris93@gmail.com>
Co-authored-by: Ewan Harris <ewanharris93@gmail.com>
Co-authored-by: Ewan Harris <ewanharris93@gmail.com>
Copy link
Member

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ewanharris ewanharris added this pull request to the merge queue Oct 10, 2024
Merged via the queue into openfga:main with commit d24b5aa Oct 10, 2024
10 checks passed
@tmsagarofficial
Copy link
Contributor Author

Hey @ewanharris can you add hacktoberfest-accepted or hacktoberfest label for this PR?

Thanks for letting me contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants